Record code slots that may point to evacuation candidate objects after deoptimizing them.

Record code slots that may point to evacuation candidate objects after deoptimizing them.

BUG=chromium:506811
LOG=n

Committed: https://crrev.com/4621210cfed738b8171b075f816f0c7329489c9d
Cr-Commit-Position: refs/heads/master@{#29466}

[Hannes Payer (out of office), 2015-07-03 10:38:49]

hpayer@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-07-03 10:46:09]

LGTM.

https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc#newcode422
src/deoptimizer.cc:422: // again that point to objects on evacuation candidates.
nit: Let's add to the comment that this is only about slots in the header of the
code object, not the instruction stream.

[Hannes Payer (out of office), 2015-07-03 10:55:54]

https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc#newcode422
src/deoptimizer.cc:422: // again that point to objects on evacuation candidates.
On 2015/07/03 10:46:09, Michael Starzinger wrote:
> nit: Let's add to the comment that this is only about slots in the header of
the
> code object, not the instruction stream.

Done.

[Hannes Payer (out of office), 2015-07-03 11:02:59]

After discussing offline, we should just remove slots after the code object
header. I will do that.

[Michael Starzinger, 2015-07-03 11:24:55]

LGTM. I like it.

https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:421: code->address() + Code::kHeaderSize, code->address() +
code->Size());
nit: We could use Code::instruction_start() here.

https://codereview.chromium.org/1225573002/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (left):

https://codereview.chromium.org/1225573002/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:421: // Eliminate all slots that point to the given
invalid_object.
nit: Comment no longer applies.

[Hannes Payer (out of office), 2015-07-03 11:26:54]

https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:421: code->address() + Code::kHeaderSize, code->address() +
code->Size());
On 2015/07/03 11:24:55, Michael Starzinger wrote:
> nit: We could use Code::instruction_start() here.

Done.

https://codereview.chromium.org/1225573002/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (left):

https://codereview.chromium.org/1225573002/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:421: // Eliminate all slots that point to the given
invalid_object.
On 2015/07/03 11:24:55, Michael Starzinger wrote:
> nit: Comment no longer applies.

Done.

[Hannes Payer (out of office), 2015-07-03 11:28:42]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-07-03 11:28:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1225573002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-07-03 11:28:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1225573002/60001

[commit-bot: I haz the power, 2015-07-03 11:49:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-03 11:49:07]

Try jobs failed on following builders:
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7272)

(exceeded global retry quota)

[Hannes Payer (out of office), 2015-07-03 12:12:16]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2015-07-03 12:12:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1225573002/60001

[commit-bot: I haz the power, 2015-07-03 12:13:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-03 12:14:09]

Patchset 4 (id:??) landed as
https://crrev.com/4621210cfed738b8171b075f816f0c7329489c9d
Cr-Commit-Position: refs/heads/master@{#29466}