Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: src/deoptimizer.cc

Issue 1225573002: Record code slots that may point to evacuation candidate objects after deoptimizing them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index 3ab10fcac905871da62fafd9cf9f658e1e7e7d48..684a37ff87ee10abe9b965a390a12c51f22f0414 100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -414,9 +414,11 @@ void Deoptimizer::DeoptimizeMarkedCodeForContext(Context* context) {
PatchCodeForDeoptimization(isolate, codes[i]);
// We might be in the middle of incremental marking with compaction.
- // Ignore all slots that might have been recorded on the deoptimized code
- // object.
- isolate->heap()->mark_compact_collector()->RemoveObjectSlots(codes[i]);
+ // Ignore all slots that might have been recorded in the body of the
+ // deoptimized code object.
+ Code* code = codes[i];
+ isolate->heap()->mark_compact_collector()->RemoveObjectSlots(
+ code->instruction_start(), code->address() + code->Size());
}
}
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698