Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Unified Diff: Source/core/rendering/InlineIterator.h

Issue 122553005: unicode-bidi: isolate is creating duplicated runs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/text/international/unicode-bidi-isolate-duplicated-text-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/InlineIterator.h
diff --git a/Source/core/rendering/InlineIterator.h b/Source/core/rendering/InlineIterator.h
index 87c42c4e4a34ff007d0ce306ed1c47d416f8e689..3e7a69e74605034ade5ee763c5ab86086f8bafd4 100644
--- a/Source/core/rendering/InlineIterator.h
+++ b/Source/core/rendering/InlineIterator.h
@@ -649,7 +649,11 @@ inline void InlineBidiResolver::appendRun()
if (isEndOfLine)
m_reachedEndOfLine = true;
- m_eor.increment();
+ // If isolateTrack is inIsolate, the next |start of run| can not be the current isolated renderer.
+ if (isolateTracker.inIsolate())
+ m_eor.moveTo(bidiNextSkippingEmptyInlines(m_eor.root(), m_eor.object()), 0);
+ else
+ m_eor.increment();
m_sor = m_eor;
}
« no previous file with comments | « LayoutTests/fast/text/international/unicode-bidi-isolate-duplicated-text-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698