presubmit_canned_checks.py - Issue 12255083: Fix PyLint presbumit check on win.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 12255083: Fix PyLint presbumit check on win. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 995aa45504c0ac1f1382d3cd98ee5b2812e125c1..a8c5203f9fec252dd3ec37a7c6c086059cc4d465 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -677,7 +677,7 @@ def RunPylint(input_api, output_api, white_list=None, black_list=None,

env = input_api.environ.copy()

import sys

env['PYTHONPATH'] = input_api.os_path.pathsep.join(

- extra_paths_list + sys.path)

+ extra_paths_list + sys.path).encode('ascii', 'ignore')

M-A Ruel 2013/02/19 21:07:40 utf8 technically we'd want the code page but utf8

robertshield 2013/02/20 15:23:37 Done.

def run_lint(files):

# We can't import pylint directly due to licensing issues, so we run

« no previous file with comments | « no previous file | no next file » | no next file with comments »