Fix PyLint presbumit check on win.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 659 matching lines @@
   files = _FetchAllFiles(input_api, white_list, black_list)
   if not files:
     return []
 
   input_api.logging.info('Running pylint on: %s', files)
   # Copy the system path to the environment so pylint can find the right
   # imports.
   env = input_api.environ.copy()
   import sys
   env['PYTHONPATH'] = input_api.os_path.pathsep.join(
-      extra_paths_list + sys.path)
+      extra_paths_list + sys.path).encode('ascii', 'ignore')

[M-A Ruel, 2013/02/19 21:07:40]

utf8
technically we'd want the code page but utf8 is close enough most of the time.
then remove 'ignore'

[robertshield, 2013/02/20 15:23:37]

Done.

 
   def run_lint(files):
     # We can't import pylint directly due to licensing issues, so we run
     # it in another process. Windows needs help running python files so we
     # explicitly specify the interpreter to use. It also has limitations on
     # the size of the command-line, so we pass arguments via a pipe.
     command = [input_api.python_executable,
                input_api.os_path.join(_HERE, 'third_party', 'pylint.py'),
                '--args-on-stdin']
     try:
@@ skipping 316 matching lines @@
     snapshot("checking description")
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
         input_api, output_api))
     results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
         input_api, output_api))
     snapshot("checking do not submit in files")
     results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles(
         input_api, output_api))
   snapshot("done")
   return results