Extension BaseFeatureProvider minor cleanups. Don't crash in release mode if we failed to parse a p…

chrome/common/extensions/extension.cc

Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 73c2d524faed6fde21c75e510c223050629e0ac2..b0ce7dee3d3294ade3a0a6c5ae4a968122665db1 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -621,7 +621,11 @@ bool Extension::ParsePermissions(const char* key,
       // The feature should exist since we just got an APIPermission
       // for it. The two systems should be updated together whenever a
       // permission is added.
-      CHECK(feature);
+      DCHECK(feature);
+      // This might happen if we have trouble loading the manifest files, but we
+      // don't want to crash the whole browser in release mode.

[not at google - send to devlin, 2013/02/15 16:33:34]

Link to bug instead of this.

[justinlin, 2013/02/21 09:18:23]

Done.

+      if (!feature)
+        continue;
 
       Feature::Availability availability =
           feature->IsAvailableToManifest(