Extension BaseFeatureProvider minor cleanups. Don't crash in release mode if we failed to parse a p…

chrome/common/extensions/extension.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
@@ skipping 603 matching lines @@
     FeatureProvider* permission_features =
         BaseFeatureProvider::GetPermissionFeatures();
     for (APIPermissionSet::const_iterator it = api_permissions->begin();
          it != api_permissions->end(); ++it) {
       extensions::Feature* feature =
           permission_features->GetFeature(it->name());
 
       // The feature should exist since we just got an APIPermission
       // for it. The two systems should be updated together whenever a
       // permission is added.
-      CHECK(feature);
+      DCHECK(feature);
+      // This might happen if we have trouble loading the manifest files, but we
+      // don't want to crash the whole browser in release mode.

[not at google - send to devlin, 2013/02/15 16:33:34]

Link to bug instead of this.

[justinlin, 2013/02/21 09:18:23]

Done.

+      if (!feature)
+        continue;
 
       Feature::Availability availability =
           feature->IsAvailableToManifest(
               id(),
               GetType(),
               Feature::ConvertLocation(location()),
               manifest_version());
       if (!availability.is_available()) {
         // Don't fail, but warn the developer that the manifest contains
         // unrecognized permissions. This may happen legitimately if the
@@ skipping 2159 matching lines @@
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}
 
 }   // namespace extensions