[es6] Check declaration conflicts between non-simple parameters and the function body

src/parser.cc

Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index 2b3f482a265c17e99d4202fa2bb798cc4972a0bd..6a944c26ff1b09e8665d34fbee1d33758b4532e2 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -4432,6 +4432,7 @@ ZoneList<Statement*>* Parser::ParseEagerFunctionBody(
     inner_scope->set_end_position(scanner()->location().end_pos);
     inner_scope = inner_scope->FinalizeBlockScope();
     inner_block->set_scope(inner_scope);
+    if (inner_scope) CheckConflictingVarDeclarations(inner_scope, CHECK_OK);

[adamk, 2015/07/15 21:12:30]

CHECK_OK shouldn't be used in a single-statement if like this (even if it would
turn out to do the right thing). Better to add a block here.

You could also guard the above inner_block->set_scope() call with this check
while you're at it. (and nit: change the condition to inner_scope != nullptr to
match surrounding code)

[rossberg, 2015/07/16 14:26:40]

Done.

   }
 
   return result;