[es6] Check declaration conflicts between non-simple parameters and the function body

src/scopes.cc

Index: src/scopes.cc
diff --git a/src/scopes.cc b/src/scopes.cc
index 41622894a122d5a844788223bcc757f121585009..a044b76baccc4c4b0d330aa0a749b5b022908610 100644
--- a/src/scopes.cc
+++ b/src/scopes.cc
@@ -575,12 +575,21 @@ Declaration* Scope::CheckConflictingVarDeclarations() {
   int length = decls_.length();
   for (int i = 0; i < length; i++) {
     Declaration* decl = decls_[i];
-    if (decl->mode() != VAR) continue;
+    if (decl->mode() != VAR && !is_block_scope()) continue;
     const AstRawString* name = decl->proxy()->raw_name();
 
     // Iterate through all scopes until and including the declaration scope.
+    // If the declaration scope is a (declaration) block scope, also continue

[adamk, 2015/07/15 21:12:30]

This weird duality of "declaration" scopes is beginning to worry me. Do you have
reason to think there aren't more places that depend on there being a single
declaration scope for a given scope?

[rossberg, 2015/07/16 14:26:40]

I admit this is hacky, but I'm not sure I fully understand your question. There
should always be a single declaration scope. But in this particular case, we
also want to check that it doesn't overlap with the surrounding one.

[adamk, 2015/07/16 17:05:13]

What I meant was that functions now can have two declaration scopes, where
previously they only had one.

[rossberg, 2015/07/17 08:27:41]

Ah, I see. No, I don't think it matters anywhere else. The notion of declaration
scope is irrelevant for anything but placing var declarations during parsing.
And this parameters-may-not-shadow-local-decls thing is an unnatural
irregularity in the spec that shouldn't exist in the first place (certainly not
for lexical bindings).

+    // (that is to handle the special inner scope of functions with
+    // destructuring parameters, which may not shadow any variables from
+    // the surrounding function scope).
     Scope* previous = NULL;
     Scope* current = decl->scope();
+    // Lexical vs lexical conflicts within the same scope have already been
+    // captured in Parser::Declare. The only conflicts we still need to check
+    // are lexical vs VAR, or any declarations within a declaration block scope
+    // vs lexical declarations in its surrounding (function) scope.
+    if (decl->mode() != VAR) current = current->outer_scope_;
     do {
       // There is a conflict if there exists a non-VAR binding.
       Variable* other_var = current->variables_.Lookup(name);
@@ -589,7 +598,7 @@ Declaration* Scope::CheckConflictingVarDeclarations() {
       }
       previous = current;
       current = current->outer_scope_;
-    } while (!previous->is_declaration_scope());
+    } while (!previous->is_declaration_scope() || previous->is_block_scope());
   }
   return NULL;
 }