Chromium Code Reviews

Issue 1225413002: [Extensions] Fix improper extension tab ownership bug (Closed)

Created:
5 years, 5 months ago by Devlin
Modified:
5 years, 5 months ago
Reviewers:
nasko, not at google - send to devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Fix improper extension tab ownership bug An extension can "own" a tab if it owns the main frame, and we block content scripts in this case. But there was a race that meant the tab wasn't being updated in time for document_start. Instead of informing the tab of its owner across IPC, use the security origin of the top frame, since this can now be accessed from remote frames as well. BUG=507461 Committed: https://crrev.com/f01734ae15fc5c2a39181b25999683d336109dbf Cr-Commit-Position: refs/heads/master@{#338300}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+56 lines, -38 lines)
M chrome/browser/extensions/content_script_apitest.cc View 3 chunks +49 lines, -0 lines 0 comments
M extensions/browser/extension_web_contents_observer.cc View 1 chunk +0 lines, -11 lines 0 comments
M extensions/common/extension_messages.h View 1 chunk +0 lines, -5 lines 0 comments
M extensions/renderer/extension_frame_helper.h View 3 chunks +0 lines, -9 lines 0 comments
M extensions/renderer/extension_frame_helper.cc View 2 chunks +0 lines, -7 lines 0 comments
M extensions/renderer/extension_injection_host.cc View 2 chunks +7 lines, -6 lines 0 comments

Messages

Total messages: 12 (4 generated)
Devlin
5 years, 5 months ago (2015-07-09 21:17:17 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/1225413002/diff/1/chrome/browser/extensions/content_script_apitest.cc File chrome/browser/extensions/content_script_apitest.cc (right): https://codereview.chromium.org/1225413002/diff/1/chrome/browser/extensions/content_script_apitest.cc#newcode582 chrome/browser/extensions/content_script_apitest.cc:582: DocumentStartInjectionFromExtensionTabNavigation) { (clang-format should fix this)
5 years, 5 months ago (2015-07-09 21:39:30 UTC) #3
Devlin
https://codereview.chromium.org/1225413002/diff/1/chrome/browser/extensions/content_script_apitest.cc File chrome/browser/extensions/content_script_apitest.cc (right): https://codereview.chromium.org/1225413002/diff/1/chrome/browser/extensions/content_script_apitest.cc#newcode582 chrome/browser/extensions/content_script_apitest.cc:582: DocumentStartInjectionFromExtensionTabNavigation) { On 2015/07/09 21:39:30, kalman wrote: > (clang-format ...
5 years, 5 months ago (2015-07-10 00:58:23 UTC) #4
Devlin
+Nasko for messages.
5 years, 5 months ago (2015-07-10 00:58:39 UTC) #6
nasko
My favorite type of CLs - code removal -> always LGTM!
5 years, 5 months ago (2015-07-10 09:11:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225413002/20001
5 years, 5 months ago (2015-07-10 15:18:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 16:03:28 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 16:04:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f01734ae15fc5c2a39181b25999683d336109dbf
Cr-Commit-Position: refs/heads/master@{#338300}

Powered by Google App Engine