Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: extensions/renderer/extension_frame_helper.h

Issue 1225413002: [Extensions] Fix improper extension tab ownership bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/renderer/extension_frame_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/extension_frame_helper.h
diff --git a/extensions/renderer/extension_frame_helper.h b/extensions/renderer/extension_frame_helper.h
index 480b42662bdfaff6d74eef2c831a8a2d9f0a058c..7e20cf8ba8b69937088df33b2613473dd946f69d 100644
--- a/extensions/renderer/extension_frame_helper.h
+++ b/extensions/renderer/extension_frame_helper.h
@@ -56,9 +56,6 @@ class ExtensionFrameHelper
ViewType view_type() const { return view_type_; }
int tab_id() const { return tab_id_; }
int browser_window_id() const { return browser_window_id_; }
- const std::string& tab_extension_owner_id() const {
- return tab_extension_owner_id_;
- }
private:
// RenderFrameObserver implementation.
@@ -85,7 +82,6 @@ class ExtensionFrameHelper
void OnExtensionDispatchOnDisconnect(int port_id,
const std::string& error_message);
void OnExtensionSetTabId(int tab_id);
- void OnSetMainFrameExtensionOwner(const std::string& extension_id);
void OnUpdateBrowserWindowId(int browser_window_id);
void OnNotifyRendererViewType(ViewType view_type);
void OnExtensionResponse(int request_id,
@@ -107,11 +103,6 @@ class ExtensionFrameHelper
// The id of the browser window the render frame is attached to.
int browser_window_id_;
- // The id of the extension that "owns" the tab if this is a chrome-extension
- // page. If it's not a chrome-extension page, |tab_extension_owner_id_| is
- // empty.
- std::string tab_extension_owner_id_;
-
Dispatcher* extension_dispatcher_;
DISALLOW_COPY_AND_ASSIGN(ExtensionFrameHelper);
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/renderer/extension_frame_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698