Issue 12254040: Revert 182494

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12254040: Revert 182494 (Closed)

Created:
7 years, 10 months ago by Ilya Sherman

Modified:
7 years, 10 months ago

Reviewers:
ynovikov

CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, ben+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 182494 Introduced new static initializers on Linux. > Add IsInternal property to gfx::Display > > Move knowledge whether a display is internal or not > from ash::DisplayManager into gfx::Display. > > BUG=171310 > TEST=ash_unittests, ui_unittests, unit_tests pass > > > Review URL: https://chromiumcodereview.appspot.com/12217120 TBR=ynovikov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182531

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -47 lines)			Patch
MM	ash/display/display_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	ash/display/display_manager.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
MM	ash/display/display_manager.cc	View	6 chunks	+10 lines, -11 lines	0 comments	Download
MM	ash/display/event_transformation_handler.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
MM	ash/system/chromeos/tray_display.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	ash/test/ash_test_base.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
MM	chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/display_options_handler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/display.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/gfx/display.cc	View	2 chunks	+6 lines, -21 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages