src/objects.cc - Issue 12254036: Minor cleanup of CompareIC state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 12254036: Minor cleanup of CompareIC state (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Actually address all comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index a65a3174fb5a4d2f6607a54a5a0e15bcf092daa3..1e486d77efd3054fe70c64281376bbaf4406b9bc 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -8749,7 +8749,7 @@ void Code::ClearTypeFeedbackCells(Heap* heap) {

bool Code::allowed_in_shared_map_code_cache() {

return is_keyed_load_stub() || is_keyed_store_stub() ||

(is_compare_ic_stub() &&

- ICCompareStub::CompareState(stub_info()) == CompareIC::KNOWN_OBJECTS);

+ ICCompareStub::CompareState(stub_info()) == CompareIC::KNOWN_OBJECT);

}

« no previous file with comments | « src/mips/code-stubs-mips.h ('k') | src/type-info.cc » ('j') | no next file with comments »