Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/objects.cc

Issue 12254036: Minor cleanup of CompareIC state (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Actually address all comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/code-stubs-mips.h ('k') | src/type-info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 8731 matching lines...) Expand 10 before | Expand all | Expand 10 after
8742 JSGlobalPropertyCell* cell = type_feedback_cells->Cell(i); 8742 JSGlobalPropertyCell* cell = type_feedback_cells->Cell(i);
8743 cell->set_value(TypeFeedbackCells::RawUninitializedSentinel(heap)); 8743 cell->set_value(TypeFeedbackCells::RawUninitializedSentinel(heap));
8744 } 8744 }
8745 } 8745 }
8746 } 8746 }
8747 8747
8748 8748
8749 bool Code::allowed_in_shared_map_code_cache() { 8749 bool Code::allowed_in_shared_map_code_cache() {
8750 return is_keyed_load_stub() || is_keyed_store_stub() || 8750 return is_keyed_load_stub() || is_keyed_store_stub() ||
8751 (is_compare_ic_stub() && 8751 (is_compare_ic_stub() &&
8752 ICCompareStub::CompareState(stub_info()) == CompareIC::KNOWN_OBJECTS); 8752 ICCompareStub::CompareState(stub_info()) == CompareIC::KNOWN_OBJECT);
8753 } 8753 }
8754 8754
8755 8755
8756 void Code::MakeCodeAgeSequenceYoung(byte* sequence) { 8756 void Code::MakeCodeAgeSequenceYoung(byte* sequence) {
8757 PatchPlatformCodeAge(sequence, kNoAge, NO_MARKING_PARITY); 8757 PatchPlatformCodeAge(sequence, kNoAge, NO_MARKING_PARITY);
8758 } 8758 }
8759 8759
8760 8760
8761 void Code::MakeOlder(MarkingParity current_parity) { 8761 void Code::MakeOlder(MarkingParity current_parity) {
8762 byte* sequence = FindCodeAgeSequence(); 8762 byte* sequence = FindCodeAgeSequence();
(...skipping 5159 matching lines...) Expand 10 before | Expand all | Expand 10 after
13922 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 13922 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
13923 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 13923 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
13924 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 13924 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
13925 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 13925 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
13926 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 13926 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
13927 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 13927 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
13928 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 13928 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
13929 } 13929 }
13930 13930
13931 } } // namespace v8::internal 13931 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.h ('k') | src/type-info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698