Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 12254021: Alternate NTP: Resize devtools when hiding bookmark bar (Closed)

Created:
7 years, 10 months ago by sail
Modified:
7 years, 10 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Alternate NTP: Resize devtools when hiding bookmark bar Hiding the bookmark bar didn't update the devtools height. Fix was to update the frame when setTopContentOffset: was called. BUG=173205 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182499

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 4 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
sail
7 years, 10 months ago (2013-02-13 22:44:06 UTC) #1
dhollowa
lgtm https://codereview.chromium.org/12254021/diff/1/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm File chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm (right): https://codereview.chromium.org/12254021/diff/1/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm#newcode112 chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm:112: CGFloat new_offset = 25; Hmm, snake-case is not ...
7 years, 10 months ago (2013-02-13 23:31:30 UTC) #2
sail
https://codereview.chromium.org/12254021/diff/1/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm File chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm (right): https://codereview.chromium.org/12254021/diff/1/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm#newcode112 chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm:112: CGFloat new_offset = 25; On 2013/02/13 23:31:30, dhollowa wrote: ...
7 years, 10 months ago (2013-02-13 23:49:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12254021/1
7 years, 10 months ago (2013-02-13 23:52:01 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 18:02:48 UTC) #5
Retried try job too often on win7_aura for step(s) ash_unittests,
aura_unittests, compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

Powered by Google App Engine
This is Rietveld 408576698