Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4742)

Unified Diff: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

Issue 12254021: Alternate NTP: Resize devtools when hiding bookmark bar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/dev_tools_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
index 98700834c3196ec58d53297fc7401a1387934627..28a29eb5d9694dd1673a420599cc6eea05e2c37a 100644
--- a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
@@ -107,4 +107,10 @@ IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, WebViewLayout) {
EXPECT_EQ(height - offset, NSHeight([web_view bounds]));
EXPECT_EQ(0, NSMinY([web_view bounds]));
+
+ // Update the offset and verify that the view is resized.
+ CGFloat new_offset = 25;
dhollowa 2013/02/13 23:31:30 Hmm, snake-case is not obj-c style, but seems to b
sail 2013/02/13 23:49:09 My understanding is that camel case is for code in
+ [controller() setTopContentOffset:new_offset];
+ EXPECT_EQ(height - new_offset, NSHeight([web_view bounds]));
+ EXPECT_EQ(0, NSMinY([web_view bounds]));
}
« no previous file with comments | « chrome/browser/ui/cocoa/dev_tools_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698