src/api.cc - Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 305fbfb5c85ec863960a0beb2e65b27d62ed9010..5d4911bb5ade1070e44ca83fc47a700fd45cce98 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -4560,7 +4560,6 @@ Persistent<Context> v8::Context::New(

// Create the environment.

env = isolate->bootstrapper()->CreateEnvironment(

- isolate,

Utils::OpenHandle(*global_object, true),

proxy_template,

extensions);

@@ -6558,8 +6557,10 @@ void Testing::PrepareStressRun(int run) {

}

+// TODO(svenpanne) Deprecate this.

void Testing::DeoptimizeAll() {

- i::HandleScope scope;

+ i::Isolate* isolate = i::Isolate::Current();

+ i::HandleScope scope(isolate);

internal::Deoptimizer::DeoptimizeAll();

}

« no previous file with comments | « src/accessors.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »