Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1225303005: [strong] class objects created in strong mode are frozen (Closed)

Created:
5 years, 5 months ago by conradw
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] class objects created in strong mode are frozen BUG=v8:3956 LOG=N Committed: https://crrev.com/4927c82ffee37ef05e132de431a71aa97f86a995 Cr-Commit-Position: refs/heads/master@{#29615}

Patch Set 1 #

Patch Set 2 : remove print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -1 line) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +8 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A test/mjsunit/strong/class-object-frozen.js View 1 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
conradw
PTAL
5 years, 5 months ago (2015-07-13 14:11:30 UTC) #2
rossberg
lgtm
5 years, 5 months ago (2015-07-13 14:57:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225303005/20001
5 years, 5 months ago (2015-07-13 14:59:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 15:00:58 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:01:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4927c82ffee37ef05e132de431a71aa97f86a995
Cr-Commit-Position: refs/heads/master@{#29615}

Powered by Google App Engine
This is Rietveld 408576698