Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1225303005: [strong] class objects created in strong mode are frozen (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove print Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 46fd17bb8bc482fbeb0b1422d763fdeadf131d63..99510e3abc8aa69cea2ab7d8d459072640fcea96 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1640,6 +1640,14 @@ void AstGraphBuilder::VisitClassLiteralContents(ClassLiteral* expr) {
const Operator* op = javascript()->CallRuntime(Runtime::kToFastProperties, 1);
NewNode(op, environment()->Pop()); // prototype
NewNode(op, environment()->Pop()); // literal
+ if (is_strong(language_mode())) {
+ // TODO(conradw): It would be more efficient to define the properties with
+ // the right attributes the first time round.
+ literal =
+ NewNode(javascript()->CallRuntime(Runtime::kObjectFreeze, 1), literal);
+ // Freezing the class object should never deopt.
+ PrepareFrameState(literal, BailoutId::None());
+ }
// Assign to class variable.
if (expr->scope() != NULL) {
@@ -1652,7 +1660,6 @@ void AstGraphBuilder::VisitClassLiteralContents(ClassLiteral* expr) {
BuildVariableAssignment(var, literal, Token::INIT_CONST, feedback,
BailoutId::None(), states);
}
-
ast_context()->ProduceValue(literal);
}
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698