Issue 12252042: android: Check whether JAVA_HOME is set incorrectly in envsetup.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12252042: android: Check whether JAVA_HOME is set incorrectly in envsetup.sh (Closed)

Created:
7 years, 10 months ago by bsalomon

Modified:
7 years, 10 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

android: Check whether JAVA_HOME is set incorrectly in envsetup.sh Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182522

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	build/android/envsetup.sh	View		1 chunk	+11 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

I tested this locally and it would have caught my problem. However, I'm not known ...

7 years, 10 months ago (2013-02-14 19:19:56 UTC) #1

Lei Zhang

lgtm I think for portable shell, one shouldn't use [[, but it's already used in ...

7 years, 10 months ago (2013-02-14 20:00:07 UTC) #2

bsalomon

7 years, 10 months ago (2013-02-14 20:11:19 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12252042/diff/1/build/android/envsetup.sh
File build/android/envsetup.sh (right):

https://codereview.chromium.org/12252042/diff/1/build/android/envsetup.sh#new...
build/android/envsetup.sh:116: if [[ ! -z "$JAVA_HOME" && -e
"$JAVA_HOME/bin/java" ]]; then
On 2013/02/14 20:00:07, Lei Zhang wrote:
> ! -z   --->   -n
> 
> -e     --->   -x

Done.

Expand Messages | Collapse Messages