Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: build/android/envsetup.sh

Issue 12252042: android: Check whether JAVA_HOME is set incorrectly in envsetup.sh (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup.sh
===================================================================
--- build/android/envsetup.sh (revision 182504)
+++ build/android/envsetup.sh (working copy)
@@ -113,6 +113,17 @@
return 1
fi
+if [[ ! -z "$JAVA_HOME" && -e "$JAVA_HOME/bin/java" ]]; then
Lei Zhang 2013/02/14 20:00:07 ! -z ---> -n -e ---> -x
bsalomon 2013/02/14 20:11:19 Done.
+ "$JAVA_HOME/bin/java" -version 2>&1 | grep -qs "Java HotSpot"
+ if [ $? -ne 0 ]; then
+ echo "If JAVA_HOME is defined then it must refer to the install location"
+ echo "of the Oracle Java SDK."
+ echo "Refer to the \"Install prerequisites\" section here:"
+ echo "https://code.google.com/p/chromium/wiki/AndroidBuildInstructions"
+ return 1
+ fi
+fi
+
# Workaround for valgrind build
if [[ -n "$CHROME_ANDROID_VALGRIND_BUILD" ]]; then
# arm_thumb=0 is a workaround for https://bugs.kde.org/show_bug.cgi?id=270709
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698