Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1225103009: Fix Asteroids game to paint again and give it an icon. (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
abarth, viktork, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix Asteroids game to paint again and give it an icon. I also fixed dependencies on Activiy and Keyboard etc which were incorrectly included only in SkyDemo despite being depended on by the Sky Framework. R=abarth@chromium.org, abarth@google.com, viktork@google.com Committed: https://chromium.googlesource.com/external/mojo/+/ac0981c646194af475c9462a8242c6e1f708b97b

Patch Set 1 #

Total comments: 3

Patch Set 2 : updated #

Messages

Total messages: 5 (1 generated)
eseidel
5 years, 5 months ago (2015-07-10 20:17:53 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/1225103009/diff/1/sky/sdk/example/game/apk/AndroidManifest.xml File sky/sdk/example/game/apk/AndroidManifest.xml (right): https://codereview.chromium.org/1225103009/diff/1/sky/sdk/example/game/apk/AndroidManifest.xml#newcode15 sky/sdk/example/game/apk/AndroidManifest.xml:15: android:theme="@android:style/Theme.Black.NoTitleBar" We should use this in all the ...
5 years, 5 months ago (2015-07-10 20:24:54 UTC) #3
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-10 20:41:25 UTC) #4
eseidel
5 years, 5 months ago (2015-07-10 20:42:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ac0981c646194af475c9462a8242c6e1f708b97b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698