Ensure that when themes in desktop chrome AURA on Windows use the opaque browser frame view.

chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/desktop_browser_frame_aura.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/views/frame/browser_desktop_root_window_host.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_observer.h"
 #include "ui/base/hit_test.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/simple_menu_model.h"
 #include "ui/gfx/font.h"
 #include "ui/views/corewm/visibility_controller.h"
 #include "ui/views/view.h"
+#include "ui/views/widget/widget.h"
+
+#if defined(OS_WIN)
+#include "chrome/browser/ui/views/frame/browser_frame_common_win.h"
+#endif
 
 using aura::Window;
 
 ///////////////////////////////////////////////////////////////////////////////
 // DesktopBrowserFrameAura, public:
 
 DesktopBrowserFrameAura::DesktopBrowserFrameAura(
     BrowserFrame* browser_frame,
     BrowserView* browser_view)
     : views::DesktopNativeWidgetAura(browser_frame),
@@ skipping 47 matching lines @@
   return browser_desktop_root_window_host_->UsesNativeSystemMenu();
 }
 
 int DesktopBrowserFrameAura::GetMinimizeButtonOffset() const {
   return browser_desktop_root_window_host_->GetMinimizeButtonOffset();
 }
 
 void DesktopBrowserFrameAura::TabStripDisplayModeChanged() {
 }
 
+bool DesktopBrowserFrameAura::ShouldUseNativeFrame() const {
+#if !defined(OS_WIN)

[sky, 2013/02/13 00:42:54]

Can you forward this to browser_desktop_root_window_host_ so we don't need the
ifdefs here?

[ananta, 2013/02/13 01:43:21]

I removed this method which achieves what you described. The 
DesktopNativeWidgetAura::ShouldUseNativeFrame override already does this, i.e.
forwards it off to the desktop_root_window_host_. I added a windows specific
implementation of this function in the BrowserDesktopRootWindowHostWin which
forwards it off to the chrome::ShouldUseNativeFrameHelper.

PTAL.

+  return views::DesktopNativeWidgetAura::ShouldUseNativeFrame();
+#else
+  return browser::ShouldUseNativeFrame(this,
+                                       browser_view_,
+                                       GetWidget()->GetThemeProvider());
+#endif
+}
+
+
 ///////////////////////////////////////////////////////////////////////////////
 // DesktopBrowserFrameAura, private:
 
 DesktopBrowserFrameAura::~DesktopBrowserFrameAura() {
 }