chrome/browser/extensions/extension_override_apitest.cc - Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_override_apitest.cc

Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_test_base

Patch Set: Comments from jhawkins, round two. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_messages_apitest.cc ('k') | chrome/browser/extensions/extension_view_host_factory_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_override_apitest.cc

diff --git a/chrome/browser/extensions/extension_override_apitest.cc b/chrome/browser/extensions/extension_override_apitest.cc

index d5eeed1c77f87b4d4c8cb7edb40764204bf9c4f3..a865c970113001004fb4239750cbbc179236b424 100644

--- a/chrome/browser/extensions/extension_override_apitest.cc

+++ b/chrome/browser/extensions/extension_override_apitest.cc

@@ -78,8 +78,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, MAYBE_OverrideNewTabIncognito) {

// Navigate an incognito tab to the new tab page. We should get the actual

// new tab page because we can't load chrome-extension URLs in incognito.

- Browser* otr_browser = ui_test_utils::OpenURLOffTheRecord(

- browser()->profile(), GURL("chrome://newtab/"));

+ Browser* otr_browser =

+ OpenURLOffTheRecord(browser()->profile(), GURL("chrome://newtab/"));

WebContents* tab = otr_browser->tab_strip_model()->GetActiveWebContents();

ASSERT_TRUE(tab->GetController().GetVisibleEntry());

EXPECT_FALSE(tab->GetController().GetVisibleEntry()->GetURL().