chrome/browser/extensions/extension_messages_apitest.cc - Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests.

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 1225093003: mac: Flush the autorelease pool after making a browser window in browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_test_base

Patch Set: Comments from jhawkins, round two. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_incognito_apitest.cc ('k') | chrome/browser/extensions/extension_override_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_messages_apitest.cc

diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc

index 4ee239573b2b78b6400d2336c964cb8597588741..f62159b374054e378d7e2d23704e4712a96085b9 100644

--- a/chrome/browser/extensions/extension_messages_apitest.cc

+++ b/chrome/browser/extensions/extension_messages_apitest.cc

@@ -686,9 +686,8 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,

scoped_refptr<const Extension> app = LoadChromiumConnectableApp();

ASSERT_TRUE(app->is_platform_app());

- Browser* incognito_browser = ui_test_utils::OpenURLOffTheRecord(

- profile()->GetOffTheRecordProfile(),

- chromium_org_url());

+ Browser* incognito_browser = OpenURLOffTheRecord(

+ profile()->GetOffTheRecordProfile(), chromium_org_url());

content::RenderFrameHost* incognito_frame = incognito_browser->

tab_strip_model()->GetActiveWebContents()->GetMainFrame();

@@ -722,7 +721,7 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,

scoped_refptr<const Extension> extension = LoadChromiumConnectableExtension();

- Browser* incognito_browser = ui_test_utils::OpenURLOffTheRecord(

+ Browser* incognito_browser = OpenURLOffTheRecord(

profile()->GetOffTheRecordProfile(), chromium_org_url());

content::RenderFrameHost* incognito_frame =

incognito_browser->tab_strip_model()

@@ -756,7 +755,7 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,

scoped_refptr<const Extension> app = LoadChromiumConnectableApp(false);

ASSERT_TRUE(app->is_platform_app());

- Browser* incognito_browser = ui_test_utils::OpenURLOffTheRecord(

+ Browser* incognito_browser = OpenURLOffTheRecord(

profile()->GetOffTheRecordProfile(), chromium_org_url());

content::RenderFrameHost* incognito_frame =

incognito_browser->tab_strip_model()

@@ -788,9 +787,8 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,

scoped_refptr<const Extension> app = LoadChromiumConnectableApp();

ASSERT_TRUE(app->is_platform_app());

- Browser* incognito_browser = ui_test_utils::OpenURLOffTheRecord(

- profile()->GetOffTheRecordProfile(),

- chromium_org_url());

+ Browser* incognito_browser = OpenURLOffTheRecord(

+ profile()->GetOffTheRecordProfile(), chromium_org_url());

content::RenderFrameHost* incognito_frame = incognito_browser->

tab_strip_model()->GetActiveWebContents()->GetMainFrame();

@@ -827,7 +825,7 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,

ASSERT_TRUE(app->is_platform_app());

// Open an incognito browser with two tabs displaying "chromium.org".

- Browser* incognito_browser = ui_test_utils::OpenURLOffTheRecord(

+ Browser* incognito_browser = OpenURLOffTheRecord(

profile()->GetOffTheRecordProfile(), chromium_org_url());

content::RenderFrameHost* incognito_frame1 =

incognito_browser->tab_strip_model()

@@ -836,9 +834,8 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,

InfoBarService* infobar_service1 = InfoBarService::FromWebContents(

incognito_browser->tab_strip_model()->GetActiveWebContents());

- CHECK(ui_test_utils::OpenURLOffTheRecord(profile()->GetOffTheRecordProfile(),

- chromium_org_url()) ==

- incognito_browser);

+ CHECK(OpenURLOffTheRecord(profile()->GetOffTheRecordProfile(),

+ chromium_org_url()) == incognito_browser);

content::RenderFrameHost* incognito_frame2 =

incognito_browser->tab_strip_model()

->GetActiveWebContents()

@@ -899,7 +896,7 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,

scoped_refptr<const Extension> extension = LoadChromiumConnectableExtension();

- Browser* incognito_browser = ui_test_utils::OpenURLOffTheRecord(

+ Browser* incognito_browser = OpenURLOffTheRecord(

profile()->GetOffTheRecordProfile(), chromium_org_url());

content::RenderFrameHost* incognito_frame =

incognito_browser->tab_strip_model()