content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java - Issue 1224963002: Refactor chromium's Linker class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java

Issue 1224963002: Refactor chromium's Linker class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update for review feedback. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/library_loader/LegacyLinker.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java

diff --git a/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java b/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java

index 61ba04dcc306f0a23bdae48c82d03510dad95493..36c3996dce74077de6af75f25bef5b5ecc5ae88c 100644

--- a/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java

+++ b/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java

@@ -77,10 +77,11 @@ public class ChromiumLinkerTestActivity extends Activity {

if (hasLowMemoryDeviceSwitch) {

memoryDeviceConfig = Linker.MEMORY_DEVICE_CONFIG_LOW;

}

- Linker.setMemoryDeviceConfig(memoryDeviceConfig);

+ Linker linker = Linker.getInstance();

+ linker.setMemoryDeviceConfig(memoryDeviceConfig);

// Register the test runner class by name.

- Linker.setTestRunnerClassName(LinkerTests.class.getName());

+ linker.setTestRunnerClassName(LinkerTests.class.getName());

// Load the library in the browser process, this will also run the test

// runner in this process.