Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 1224963002: Refactor chromium's Linker class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update for review feedback. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
index 03f312b257810c295d2f30d0fd36375f3ee39d8f..13620da37f41459f2b5c764a5ce937dff8570c2f 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
@@ -271,9 +271,10 @@ public class ChildProcessLauncher {
private static long sLinkerLoadAddress = 0;
private static ChromiumLinkerParams getLinkerParamsForNewConnection() {
+ Linker linker = Linker.getInstance();
if (!sLinkerInitialized) {
- if (Linker.isUsed()) {
- sLinkerLoadAddress = Linker.getBaseLoadAddress();
+ if (linker.isUsed()) {
+ sLinkerLoadAddress = linker.getBaseLoadAddress();
if (sLinkerLoadAddress == 0) {
Log.i(TAG, "Shared RELRO support disabled!");
}
@@ -287,7 +288,7 @@ public class ChildProcessLauncher {
final boolean waitForSharedRelros = true;
return new ChromiumLinkerParams(sLinkerLoadAddress,
waitForSharedRelros,
- Linker.getTestRunnerClassName());
+ linker.getTestRunnerClassName());
}
private static ChildProcessConnection allocateBoundConnection(Context context,
@@ -620,7 +621,7 @@ public class ChildProcessLauncher {
filesToBeMapped,
createCallback(childProcessId, callbackType),
connectionCallback,
- Linker.getSharedRelros());
+ Linker.getInstance().getSharedRelros());
}
/**

Powered by Google App Engine
This is Rietveld 408576698