chrome/chrome_tests_unit.gypi - Issue 12248009: Created unit test for PrinterJobHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 12248009: Created unit test for PrinterJobHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_printerjobhandler

Patch Set: Adding namespace close comments and newline before EOF Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/service/cloud_print/printer_job_handler_unittest.cc » ('j') | chrome/service/cloud_print/printer_job_handler_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index 0ef6721aeef27090bfb51c6d1206a8370b6ca223..e89756349a28489411e32d7b32024b20456a202e 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -1600,6 +1600,9 @@

'service/cloud_print/cloud_print_token_store_unittest.cc',

'service/cloud_print/cloud_print_url_fetcher_unittest.cc',

'service/cloud_print/connector_settings_unittest.cc',

+ 'service/cloud_print/printer_job_handler_unittest.cc',

+ 'service/cloud_print/printer_job_handler_unittest_constants.cc',

+ 'service/cloud_print/printer_job_handler_unittest_constants.h',

Vitaly Buka (NO REVIEWS) 2013/02/12 21:45:15 Why do you need separate constants file?

Noam Samuel (WRONG ACCOUNT) 2013/02/12 21:53:18 The constants were becoming very long and cumberso

Vitaly Buka (NO REVIEWS) 2013/02/12 22:00:22 usually we don't do that for unit tests. So please

Noam Samuel (WRONG ACCOUNT) 2013/02/12 22:50:18 Done.

'service/service_process_prefs_unittest.cc',

'service/service_process_unittest.cc',

'test/base/browser_with_test_window_test.cc',

« no previous file with comments | « no previous file | chrome/service/cloud_print/printer_job_handler_unittest.cc » ('j') | chrome/service/cloud_print/printer_job_handler_unittest.cc » ('J')