Created unit test for PrinterJobHandler

chrome/chrome_tests_unit.gypi

  # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'targets': [
     {
       # This target contains mocks and test utilities that don't belong in
       # production libraries but are used by more than one test executable.
       'target_name': 'test_support_common',
       'type': 'static_library',
@@ skipping 1582 matching lines @@
         'renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc',
         'renderer/spellchecker/spellcheck_provider_mac_unittest.cc',
         'renderer/spellchecker/spellcheck_provider_test.cc',
         'renderer/spellchecker/spellcheck_provider_test.h',
         'renderer/spellchecker/spellcheck_unittest.cc',
         'renderer/spellchecker/spellcheck_worditerator_unittest.cc',
         'service/cloud_print/cloud_print_helpers_unittest.cc',
         'service/cloud_print/cloud_print_token_store_unittest.cc',
         'service/cloud_print/cloud_print_url_fetcher_unittest.cc',
         'service/cloud_print/connector_settings_unittest.cc',
+        'service/cloud_print/printer_job_handler_unittest.cc',
+        'service/cloud_print/printer_job_handler_unittest_constants.cc',
+        'service/cloud_print/printer_job_handler_unittest_constants.h',

[Vitaly Buka (NO REVIEWS), 2013/02/12 21:45:15]

Why do you need separate constants file?

[Noam Samuel (WRONG ACCOUNT), 2013/02/12 21:53:18]

The constants were becoming very long and cumbersome by their own right, so I
factored them out into a separate file.

[Vitaly Buka (NO REVIEWS), 2013/02/12 22:00:22]

usually we don't do that for unit tests.
So please move them there.

On 2013/02/12 21:53:18, Noam Samuel wrote:

[Noam Samuel (WRONG ACCOUNT), 2013/02/12 22:50:18]

Done.

         'service/service_process_prefs_unittest.cc',
         'service/service_process_unittest.cc',
         'test/base/browser_with_test_window_test.cc',
         'test/base/browser_with_test_window_test.h',
         'test/base/chrome_render_view_test.cc',
         'test/base/chrome_render_view_test.h',
         'test/base/menu_model_test.cc',
         'test/base/menu_model_test.h',
         'test/base/v8_unit_test.cc',
         'test/base/v8_unit_test.h',
@@ skipping 765 matching lines @@
               # more details.
               'DebugInformationFormat': '3',
               'ProgramDataBaseFileName': '<(PRODUCT_DIR)/unit_tests.exe.pdb',
             },
           },
         },
       ],
     }],
   ],  # 'conditions'
 }