src/ast.h - Issue 1224793002: Loads and stores to global vars are now made via property cell shortcuts installed into parent scri…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.h

Issue 1224793002: Loads and stores to global vars are now made via property cell shortcuts installed into parent scri… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.h

diff --git a/src/ast.h b/src/ast.h

index e5842c292e57b139f7073dd3f05c9508aa2db411..ddba5dfa3763858add67971656b7fb2359e50dc6 100644

--- a/src/ast.h

+++ b/src/ast.h

@@ -1660,7 +1660,7 @@ class VariableProxy final : public Expression {

void BindTo(Variable* var);

bool UsesVariableFeedbackSlot() const {

- return var()->IsUnallocatedOrGlobalSlot() || var()->IsLookupSlot();

+ return var()->IsUnallocated() || var()->IsLookupSlot();

}

virtual FeedbackVectorRequirements ComputeFeedbackRequirements(

« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ast.cc » ('j') | no next file with comments »