Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: src/ast.h

Issue 1224793002: Loads and stores to global vars are now made via property cell shortcuts installed into parent scri… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ast.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_H_ 5 #ifndef V8_AST_H_
6 #define V8_AST_H_ 6 #define V8_AST_H_
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 1642 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 void set_is_resolved() { 1653 void set_is_resolved() {
1654 bit_field_ = IsResolvedField::update(bit_field_, true); 1654 bit_field_ = IsResolvedField::update(bit_field_, true);
1655 } 1655 }
1656 1656
1657 int end_position() const { return end_position_; } 1657 int end_position() const { return end_position_; }
1658 1658
1659 // Bind this proxy to the variable var. 1659 // Bind this proxy to the variable var.
1660 void BindTo(Variable* var); 1660 void BindTo(Variable* var);
1661 1661
1662 bool UsesVariableFeedbackSlot() const { 1662 bool UsesVariableFeedbackSlot() const {
1663 return var()->IsUnallocatedOrGlobalSlot() || var()->IsLookupSlot(); 1663 return var()->IsUnallocated() || var()->IsLookupSlot();
1664 } 1664 }
1665 1665
1666 virtual FeedbackVectorRequirements ComputeFeedbackRequirements( 1666 virtual FeedbackVectorRequirements ComputeFeedbackRequirements(
1667 Isolate* isolate, const ICSlotCache* cache) override; 1667 Isolate* isolate, const ICSlotCache* cache) override;
1668 1668
1669 void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot, 1669 void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot,
1670 ICSlotCache* cache) override; 1670 ICSlotCache* cache) override;
1671 Code::Kind FeedbackICSlotKind(int index) override { return Code::LOAD_IC; } 1671 Code::Kind FeedbackICSlotKind(int index) override { return Code::LOAD_IC; }
1672 FeedbackVectorICSlot VariableFeedbackSlot() { 1672 FeedbackVectorICSlot VariableFeedbackSlot() {
1673 DCHECK(!UsesVariableFeedbackSlot() || !variable_feedback_slot_.IsInvalid()); 1673 DCHECK(!UsesVariableFeedbackSlot() || !variable_feedback_slot_.IsInvalid());
(...skipping 1932 matching lines...) Expand 10 before | Expand all | Expand 10 after
3606 3606
3607 private: 3607 private:
3608 Zone* zone_; 3608 Zone* zone_;
3609 AstValueFactory* ast_value_factory_; 3609 AstValueFactory* ast_value_factory_;
3610 }; 3610 };
3611 3611
3612 3612
3613 } } // namespace v8::internal 3613 } } // namespace v8::internal
3614 3614
3615 #endif // V8_AST_H_ 3615 #endif // V8_AST_H_
OLDNEW
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698