Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/devtools/device/port_forwarding_browsertest.cc

Issue 1224743002: DevTools: allow to pass list of remote debugging targets as command line argument (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed port forwarding test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/port_forwarding_browsertest.cc
diff --git a/chrome/browser/devtools/device/port_forwarding_browsertest.cc b/chrome/browser/devtools/device/port_forwarding_browsertest.cc
index 4fb3c62d930a5f232d9671ec0d9f994b5255c79f..6d8d75681ed9eb4de5c3682628d54a6db4672350 100644
--- a/chrome/browser/devtools/device/port_forwarding_browsertest.cc
+++ b/chrome/browser/devtools/device/port_forwarding_browsertest.cc
@@ -81,7 +81,10 @@ IN_PROC_BROWSER_TEST_F(PortForwardingTest,
Profile* profile = browser()->profile();
AndroidDeviceManager::DeviceProviders device_providers;
- device_providers.push_back(new SelfAsDeviceProvider(kDefaultDebuggingPort));
+
+ SelfAsDeviceProvider::RemoteTargets targets;
+ targets.insert(net::HostPortPair("127.0.0.1", kDefaultDebuggingPort));
dgozman 2015/07/06 10:08:34 Can we make a static method in SelfAsDeviceProvide
yurys 2015/07/06 13:57:07 Done.
+ device_providers.push_back(new SelfAsDeviceProvider(targets));
DevToolsAndroidBridge::Factory::GetForProfile(profile)->
set_device_providers_for_test(device_providers);
@@ -149,8 +152,10 @@ IN_PROC_BROWSER_TEST_F(PortForwardingDisconnectTest, DisconnectOnRelease) {
AndroidDeviceManager::DeviceProviders device_providers;
+ SelfAsDeviceProvider::RemoteTargets targets;
+ targets.insert(net::HostPortPair("127.0.0.1", kAlternativeDebuggingPort));
scoped_refptr<SelfAsDeviceProvider> self_provider(
- new SelfAsDeviceProvider(kAlternativeDebuggingPort));
+ new SelfAsDeviceProvider(targets));
device_providers.push_back(self_provider);
DevToolsAndroidBridge::Factory::GetForProfile(profile)->

Powered by Google App Engine
This is Rietveld 408576698