Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/devtools/device/self_device_provider.h

Issue 1224743002: DevTools: allow to pass list of remote debugging targets as command line argument (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed port forwarding test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/self_device_provider.h
diff --git a/chrome/browser/devtools/device/self_device_provider.h b/chrome/browser/devtools/device/self_device_provider.h
index 4200dc3b3965f4d0047525c596af4a155f6b1b56..3dd491abf618791a7c3fa529ba6d51bc40d37723 100644
--- a/chrome/browser/devtools/device/self_device_provider.h
+++ b/chrome/browser/devtools/device/self_device_provider.h
@@ -5,12 +5,16 @@
#ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_SELF_DEVICE_PROVIDER_H_
#define CHROME_BROWSER_DEVTOOLS_DEVICE_SELF_DEVICE_PROVIDER_H_
+#include <set>
+
#include "chrome/browser/devtools/device/android_device_manager.h"
+#include "net/base/host_port_pair.h"
// Instantiate this class only in a test and/or when DEBUG_DEVTOOLS is defined.
class SelfAsDeviceProvider : public AndroidDeviceManager::DeviceProvider {
dgozman 2015/07/06 10:08:34 This is not a "SelfAsDeviceProvider" anymore, let'
yurys 2015/07/06 13:57:07 Done.
public:
- explicit SelfAsDeviceProvider(int port);
+ using RemoteTargets = std::set<net::HostPortPair>;
dgozman 2015/07/06 10:08:34 Using RemoteTargets for this if confusing, as we h
yurys 2015/07/06 13:57:07 Done.
+ explicit SelfAsDeviceProvider(const RemoteTargets& targets);
void QueryDevices(const SerialsCallback& callback) override;
@@ -28,7 +32,7 @@ class SelfAsDeviceProvider : public AndroidDeviceManager::DeviceProvider {
private:
~SelfAsDeviceProvider() override;
- int port_;
+ RemoteTargets targets_;
base::Closure release_callback_;
};

Powered by Google App Engine
This is Rietveld 408576698