Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart

Issue 122463002: Fix version_negotiation_test timing out. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/pub.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
diff --git a/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart b/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
index 64247ea1b453a9d6d05b2a1c995750a03303b7e5..5117afe627e99dff779c7688419d325dbc8c186f 100644
--- a/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
+++ b/sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart
@@ -54,12 +54,6 @@ main() {
request.response.close();
});
- // TODO(nweiz): this shouldn't request the versions twice (issue 11077).
Anders Johnsen 2014/01/05 20:47:00 How is removing this test fixing the issue? :)
Bob Nystrom 2014/01/06 18:56:23 This isn't removing the test. :) What this test d
Anders Johnsen 2014/01/07 05:59:29 Ahh, I see - great then ;)
- server.handle('GET', '/api/packages/foo', (request) {
- request.response.statusCode = 406;
- request.response.close();
- });
-
pub.shouldExit(1);
expect(pub.remainingStderr(), completion(equals(
« no previous file with comments | « sdk/lib/_internal/pub/pub.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698