Fix version_negotiation_test timing out.

Fix version_negotiation_test timing out.

BUG=https://code.google.com/p/dart/issues/detail?id=14346
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31641

[Bob Nystrom, 2013-12-30 18:59:32]

At the very least, this cleans up a TODO and gets rid of some unneeded code in
the solver. The test is faster on my machine now, so hopefully this will help?

[Anders Johnsen, 2014-01-05 20:47:00]

DBC

https://codereview.chromium.org/122463002/diff/1/sdk/lib/_internal/pub/test/h...
File sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart (left):

https://codereview.chromium.org/122463002/diff/1/sdk/lib/_internal/pub/test/h...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:57: //
TODO(nweiz): this shouldn't request the versions twice (issue 11077).
How is removing this test fixing the issue? :)

[Bob Nystrom, 2014-01-06 18:56:22]

https://codereview.chromium.org/122463002/diff/1/sdk/lib/_internal/pub/test/h...
File sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart (left):

https://codereview.chromium.org/122463002/diff/1/sdk/lib/_internal/pub/test/h...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:57: //
TODO(nweiz): this shouldn't request the versions twice (issue 11077).
On 2014/01/05 20:47:00, Anders Johnsen wrote:
> How is removing this test fixing the issue? :)

This isn't removing the test. :)

What this test does is spin up a test server, and then it runs pub. Pub should
hit that server, and then this test evaluates what pub outputs.

Previously, pub was sending two HTTP requests to that server. It never should
have. I fixed the code in the version solver that led to that, so now I can
remove it here.

As a nice side effect, this test is now a bit faster since pub is doing less
networking. I'm *hoping* this means it won't time out anymore, but we'll have to
see how it goes on the bots.

[nweiz, 2014-01-06 23:55:04]

lgtm, although I'd be a little surprised if this were enough to stop the bot
timeouts, since it looks like they're caused by a dangling reference to
something HTTP-related.

[Anders Johnsen, 2014-01-07 05:59:29]

https://codereview.chromium.org/122463002/diff/1/sdk/lib/_internal/pub/test/h...
File sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart (left):

https://codereview.chromium.org/122463002/diff/1/sdk/lib/_internal/pub/test/h...
sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart:57: //
TODO(nweiz): this shouldn't request the versions twice (issue 11077).
On 2014/01/06 18:56:23, Bob Nystrom wrote:
> On 2014/01/05 20:47:00, Anders Johnsen wrote:
> > How is removing this test fixing the issue? :)
> 
> This isn't removing the test. :)
> 
> What this test does is spin up a test server, and then it runs pub. Pub should
> hit that server, and then this test evaluates what pub outputs.
> 
> Previously, pub was sending two HTTP requests to that server. It never should
> have. I fixed the code in the version solver that led to that, so now I can
> remove it here.
> 
> As a nice side effect, this test is now a bit faster since pub is doing less
> networking. I'm *hoping* this means it won't time out anymore, but we'll have
to
> see how it goes on the bots.

Ahh, I see - great then ;)

[Bob Nystrom, 2014-01-09 01:02:35]

Committed patchset #1 manually as r31641 (presubmit successful).

[Bob Nystrom, 2014-01-09 01:03:13]

I'll give it a try. If it's still flaky, I'll just mark it flaky again and leave
the bug open. Either way, this is a change for the better.