Issue 1224623007: Add mojo_services pub dependency from sky sdk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1224623007: Add mojo_services pub dependency from sky sdk (Closed)

Created:
5 years, 5 months ago by Cutch

Modified:
5 years, 5 months ago

Reviewers:
eseidel, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sky/sdk/pubspec.yaml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

eseidel

lgtm Should sky depend on this, or is it transitive through mojo or mojom?

5 years, 5 months ago (2015-07-06 20:05:43 UTC) #6

Cutch

On 2015/07/06 20:05:43, eseidel wrote: > lgtm > > Should sky depend on this, or ...

5 years, 5 months ago (2015-07-06 20:10:41 UTC) #7

Cutch

5 years, 5 months ago (2015-07-06 20:31:28 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3de9766f710cd316dc1d277f908d74583ac28431 (presubmit successful).