Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224623004: Make v8::Handle as "deprecated soon" (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
Paweł Hajdan Jr., v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make v8::Handle as "deprecated soon" BUG=v8:4131 R=bmeurer@chromium.org LOG=n Committed: https://crrev.com/f022e53b9579457d53ee59b46ce6a959d27669a4 Cr-Commit-Position: refs/heads/master@{#29473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -669 lines) Patch
M include/v8.h View 98 chunks +264 lines, -276 lines 0 comments Download
M include/v8-debug.h View 4 chunks +15 lines, -15 lines 0 comments Download
M include/v8-profiler.h View 8 chunks +13 lines, -12 lines 0 comments Download
M src/api.cc View 110 chunks +209 lines, -236 lines 0 comments Download
M src/arguments.h View 3 chunks +9 lines, -9 lines 0 comments Download
M src/arguments.cc View 2 chunks +38 lines, -39 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/debug.cc View 7 chunks +15 lines, -17 lines 0 comments Download
M src/extensions/externalize-string-extension.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/externalize-string-extension.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/extensions/free-buffer-extension.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/free-buffer-extension.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/extensions/gc-extension.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/gc-extension.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/statistics-extension.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/trigger-failure-extension.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/trigger-failure-extension.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 8 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-06 06:38:25 UTC) #1
jochen (gone - plz use gerrit)
mechanical replacement of v8::Handle with v8::Local
5 years, 5 months ago (2015-07-06 06:40:12 UTC) #2
Benedikt Meurer
LGTM (rubber-stamped)
5 years, 5 months ago (2015-07-06 06:41:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224623004/1
5 years, 5 months ago (2015-07-06 07:07:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 07:09:13 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 07:09:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f022e53b9579457d53ee59b46ce6a959d27669a4
Cr-Commit-Position: refs/heads/master@{#29473}

Powered by Google App Engine
This is Rietveld 408576698