Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: include/v8-profiler.h

Issue 1224623004: Make v8::Handle as "deprecated soon" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8-debug.h ('k') | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index d0375a79ec4e20ad63fd94985f36bdcb9506b009..121e8030a140d7d0565c194a054df38714f88ed6 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -60,13 +60,13 @@ class V8_EXPORT CpuProfileNode {
};
/** Returns function name (empty string for anonymous functions.) */
- Handle<String> GetFunctionName() const;
+ Local<String> GetFunctionName() const;
/** Returns id of the script where function is located. */
int GetScriptId() const;
/** Returns resource name for script from where the function originates. */
- Handle<String> GetScriptResourceName() const;
+ Local<String> GetScriptResourceName() const;
/**
* Returns the number, 1-based, of the line where the function originates.
@@ -129,7 +129,7 @@ class V8_EXPORT CpuProfileNode {
class V8_EXPORT CpuProfile {
public:
/** Returns CPU profile title. */
- Handle<String> GetTitle() const;
+ Local<String> GetTitle() const;
/** Returns the root node of the top down call tree. */
const CpuProfileNode* GetTopDownRoot() const;
@@ -198,13 +198,13 @@ class V8_EXPORT CpuProfiler {
* |record_samples| parameter controls whether individual samples should
* be recorded in addition to the aggregated tree.
*/
- void StartProfiling(Handle<String> title, bool record_samples = false);
+ void StartProfiling(Local<String> title, bool record_samples = false);
/**
* Stops collecting CPU profile with a given title and returns it.
* If the title given is empty, finishes the last profile started.
*/
- CpuProfile* StopProfiling(Handle<String> title);
+ CpuProfile* StopProfiling(Local<String> title);
/**
* Tells the profiler whether the embedder is idle.
@@ -246,7 +246,7 @@ class V8_EXPORT HeapGraphEdge {
* Returns edge name. This can be a variable name, an element index, or
* a property name.
*/
- Handle<Value> GetName() const;
+ Local<Value> GetName() const;
/** Returns origin node. */
const HeapGraphNode* GetFromNode() const;
@@ -287,7 +287,7 @@ class V8_EXPORT HeapGraphNode {
* of the constructor (for objects), the name of the function (for
* closures), string value, or an empty string (for compiled code).
*/
- Handle<String> GetName() const;
+ Local<String> GetName() const;
/**
* Returns node id. For the same heap object, the id remains the same
@@ -430,8 +430,8 @@ class V8_EXPORT HeapProfiler {
* while the callback is running: only getters on the handle and
* GetPointerFromInternalField on the objects are allowed.
*/
- typedef RetainedObjectInfo* (*WrapperInfoCallback)
- (uint16_t class_id, Handle<Value> wrapper);
+ typedef RetainedObjectInfo* (*WrapperInfoCallback)(uint16_t class_id,
+ Local<Value> wrapper);
/** Returns the number of snapshots taken. */
int GetSnapshotCount();
@@ -443,13 +443,13 @@ class V8_EXPORT HeapProfiler {
* Returns SnapshotObjectId for a heap object referenced by |value| if
* it has been seen by the heap profiler, kUnknownObjectId otherwise.
*/
- SnapshotObjectId GetObjectId(Handle<Value> value);
+ SnapshotObjectId GetObjectId(Local<Value> value);
/**
* Returns heap object with given SnapshotObjectId if the object is alive,
* otherwise empty handle is returned.
*/
- Handle<Value> FindObjectById(SnapshotObjectId id);
+ Local<Value> FindObjectById(SnapshotObjectId id);
/**
* Clears internal map from SnapshotObjectId to heap object. The new objects
@@ -474,7 +474,8 @@ class V8_EXPORT HeapProfiler {
* Returns name to be used in the heap snapshot for given node. Returned
* string must stay alive until snapshot collection is completed.
*/
- virtual const char* GetName(Handle<Object> object) = 0;
+ virtual const char* GetName(Local<Object> object) = 0;
+
protected:
virtual ~ObjectNameResolver() {}
};
« no previous file with comments | « include/v8-debug.h ('k') | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698