content/common/service_worker/service_worker_types.h - Issue 1224553010: Replace base::str[n]casecmp with helper functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_types.h

Issue 1224553010: Replace base::str[n]casecmp with helper functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/service_worker/service_worker_types.h

diff --git a/content/common/service_worker/service_worker_types.h b/content/common/service_worker/service_worker_types.h

index 7f25293c98247d0862c07a1d5330cf8954e4812d..7d7f1a30840d9037a09a526e362a33ddf3bf379c 100644

--- a/content/common/service_worker/service_worker_types.h

+++ b/content/common/service_worker/service_worker_types.h

@@ -101,7 +101,7 @@ enum ServiceWorkerFetchEventResult {

struct ServiceWorkerCaseInsensitiveCompare {

bool operator()(const std::string& lhs, const std::string& rhs) const {

- return base::strcasecmp(lhs.c_str(), rhs.c_str()) < 0;

+ return base::CompareCaseInsensitiveASCII(lhs, rhs) < 0;

}

};