chrome/chrome_tests_unit.gypi - Issue 1224553010: Replace base::str[n]casecmp with helper functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 1224553010: Replace base::str[n]casecmp with helper functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/printing_layout_browsertest.cc ('k') | chrome/service/cloud_print/cloud_print_connector.cc » ('j') | net/base/mime_sniffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index d638fbeb835323e0a30614b6e2a0f0e16b13c7c4..681fec7d5ef0b85fe5a1d1c7d9a27136fe0c2745 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -74,8 +74,6 @@

'browser/content_settings/host_content_settings_map_unittest.cc',

'browser/content_settings/mock_settings_observer.cc',

'browser/content_settings/mock_settings_observer.h',

- 'browser/content_settings/permission_context_base_unittest.cc',

- 'browser/content_settings/permission_queue_controller_unittest.cc',

'browser/content_settings/tab_specific_content_settings_unittest.cc',

'browser/custom_handlers/protocol_handler_registry_unittest.cc',

'browser/devtools/device/webrtc/devtools_bridge_instances_request_unittest.cc',

@@ -169,7 +167,9 @@

'browser/password_manager/password_store_x_unittest.cc',

'browser/password_manager/save_password_infobar_delegate_unittest.cc',

'browser/password_manager/simple_password_store_mac_unittest.cc',

+ 'browser/permissions/permission_context_base_unittest.cc',

'browser/permissions/permission_manager_unittest.cc',

+ 'browser/permissions/permission_queue_controller_unittest.cc',

'browser/predictors/autocomplete_action_predictor_table_unittest.cc',

'browser/predictors/autocomplete_action_predictor_unittest.cc',

'browser/predictors/resource_prefetch_common_unittest.cc',

@@ -533,9 +533,6 @@

'common/chrome_paths_unittest.cc',

'common/cloud_print/cloud_print_helpers_unittest.cc',

'common/crash_keys_unittest.cc',

- 'common/favicon/fallback_icon_url_parser_unittest.cc',

- 'common/favicon/favicon_url_parser_unittest.cc',

- 'common/favicon/large_icon_url_parser_unittest.cc',

Nico 2015/07/08 22:44:34 this still looks off. git branch issues?

'common/ini_parser_unittest.cc',

'common/instant_types_unittest.cc',

'common/mac/cfbundle_blocker_unittest.mm',

@@ -711,7 +708,6 @@

'browser/extensions/api/web_request/web_request_api_unittest.cc',

'browser/extensions/api/web_request/web_request_permissions_unittest.cc',

'browser/extensions/app_data_migrator_unittest.cc',

- 'browser/extensions/app_sync_data_unittest.cc',

'browser/extensions/blacklist_state_fetcher_unittest.cc',

'browser/extensions/bookmark_app_helper_unittest.cc',

'browser/extensions/chrome_app_sorting_unittest.cc',

« no previous file with comments | « chrome/browser/printing/printing_layout_browsertest.cc ('k') | chrome/service/cloud_print/cloud_print_connector.cc » ('j') | net/base/mime_sniffer.cc » ('J')