chrome/service/cloud_print/cloud_print_connector.cc - Issue 1224553010: Replace base::str[n]casecmp with helper functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_connector.cc

Issue 1224553010: Replace base::str[n]casecmp with helper functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/cloud_print/cloud_print_connector.cc

diff --git a/chrome/service/cloud_print/cloud_print_connector.cc b/chrome/service/cloud_print/cloud_print_connector.cc

index a1f6be7f667ae36c421ccd0a1a8b09d95979792f..f53c865e6abe7b2db51ad5b79b70b492f371aaeb 100644

--- a/chrome/service/cloud_print/cloud_print_connector.cc

+++ b/chrome/service/cloud_print/cloud_print_connector.cc

@@ -653,7 +653,7 @@ void CloudPrintConnector::OnReceivePrinterCaps(

bool CloudPrintConnector::IsSamePrinter(const std::string& name1,

const std::string& name2) const {

- return (0 == base::strcasecmp(name1.c_str(), name2.c_str()));

+ return base::EqualsCaseInsensitiveASCII(name1, name2);

}

} // namespace cloud_print