Replace base::str[n]casecmp with helper functions.

Replace base::str[n]casecmp with helper functions.

Adds CompareCaseInsensitiveASCII and EqualsCaseInsensitiveASCII helper functions and removes base::strcasecmp and base::strncasecmp. This avoids the dangerous locale-sensitive behavior.

ClientIsAdvertisingSdchEncoding in sdch_browsertest had the condition inverted, but because it returned true any time the given line wasn't found, the test didn't notice.

cups_helper changed most significantly. I redid the loop to use StringPieces which saves a lot of copies. On line 82 cups_helper used to do a prefix match which I'm pretty sure it wanted a regular compare. I changed this.

render_text_harfbuzz set "<" operator was also doing a prefix comparison only, when it looks like it really just wanted to compare the strings.

file_path passed string pieces into strcasecmp which could then read off the end if they're not null terminated. This patch fixes the bug and calls the native strcasecmp which is probably the best we can do for Posix file names.

Removed additional version of the same function in net.

Adds a backwards-compat hack for crashpad which improperly uses base from a DEPS-ed in repo.

Committed: https://crrev.com/8a800901b78a29e33bc91b48621cec72964a1f14
Cr-Commit-Position: refs/heads/master@{#338324}

[brettw, 2015-07-07 21:25:28]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 21:26:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/40001

[brettw, 2015-07-07 21:40:42]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 21:40:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/60001

[brettw, 2015-07-07 21:52:24]

.

[brettw, 2015-07-07 21:52:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 21:54:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/80001

[commit-bot: I haz the power, 2015-07-07 22:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 22:23:11]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

(exceeded global retry quota)

[brettw, 2015-07-07 22:42:31]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 22:43:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/100001

[brettw, 2015-07-07 22:43:31]

brettw@chromium.org changed reviewers:
+ thakis@chromium.org

[brettw, 2015-07-07 22:43:31]

Another part of removing locale-dependent case comparison calls.

[commit-bot: I haz the power, 2015-07-08 00:08:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 00:08:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

(exceeded global retry quota)

[brettw, 2015-07-08 20:08:07]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-08 20:09:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/120001

[commit-bot: I haz the power, 2015-07-08 20:23:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 20:23:24]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-07-08 20:59:02]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-08 21:00:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/140001

[commit-bot: I haz the power, 2015-07-08 21:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 21:24:13]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Nico, 2015-07-08 21:58:24]

https://codereview.chromium.org/1224553010/diff/140001/base/strings/string_ut...
File base/strings/string_util.h (right):

https://codereview.chromium.org/1224553010/diff/140001/base/strings/string_ut...
base/strings/string_util.h:98: // DO NOT USE. tolower() will given incorrect
results for non-ASCII characters.
suggest what to do instead?

https://codereview.chromium.org/1224553010/diff/140001/chrome/chrome_tests_un...
File chrome/chrome_tests_unit.gypi (left):

https://codereview.chromium.org/1224553010/diff/140001/chrome/chrome_tests_un...
chrome/chrome_tests_unit.gypi:538:
'common/favicon/large_icon_url_parser_unittest.cc',
?

https://codereview.chromium.org/1224553010/diff/140001/chrome/chrome_tests_un...
chrome/chrome_tests_unit.gypi:714:
'browser/extensions/app_sync_data_unittest.cc',
?

https://codereview.chromium.org/1224553010/diff/140001/media/video/capture/fa...
File media/video/capture/fake_video_capture_device_factory.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/media/video/capture/fa...
media/video/capture/fake_video_capture_device_factory.cc:29: else if
(base::EqualsCaseInsensitiveASCII(option, "triplanar") == 0)
remove == 0 at end

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_sniffer.cc
File net/base/mime_sniffer.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_sniffer....
net/base/mime_sniffer.cc:349: base::StringPiece(content, len));
This previously only compared the first len bytes of both strings – is this
intentionally not a prefix change on the rhs?

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_util.cc#...
net/base/mime_util.cc:118: if (end_pos == ext.size() &&
I was about to say that EqualsCase...() already does an early check for size, so
you could delete this, but it's actually required to make the StringPiece()
below not point at uninitialized memory if ext is long. A bit subtle.

https://codereview.chromium.org/1224553010/diff/140001/net/cookies/cookie_uti...
File net/cookies/cookie_util.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/net/cookies/cookie_uti...
net/cookies/cookie_util.cc:129: token, base::StringPiece(kMonths[i], 3))) {
nit: StartsWith?

https://codereview.chromium.org/1224553010/diff/140001/net/http/http_request_...
File net/http/http_request_headers.cc (left):

https://codereview.chromium.org/1224553010/diff/140001/net/http/http_request_...
net/http/http_request_headers.cc:244: if (key.length() == it->key.length() &&
Don't you need this check in case one string piece is shorter than the other and
not 0 terminated? Without the check you end up comparing uninitialized memory in
one of the two string pieces in that case

https://codereview.chromium.org/1224553010/diff/140001/net/http/http_request_...
net/http/http_request_headers.cc:257: !base::strncasecmp(key.data(),
it->key.data(), key.length()))
likewise

https://codereview.chromium.org/1224553010/diff/140001/net/tools/balsa/string...
File net/tools/balsa/string_piece_utils.h (left):

https://codereview.chromium.org/1224553010/diff/140001/net/tools/balsa/string...
net/tools/balsa/string_piece_utils.h:68: struct StringPieceUtils {
Is this the "we can't use chromium's base for we must build in google's internal
codebase" thing again? +rch

[brettw, 2015-07-08 22:35:17]

Thanks for the thorough review!

https://codereview.chromium.org/1224553010/diff/140001/chrome/chrome_tests_un...
File chrome/chrome_tests_unit.gypi (left):

https://codereview.chromium.org/1224553010/diff/140001/chrome/chrome_tests_un...
chrome/chrome_tests_unit.gypi:714:
'browser/extensions/app_sync_data_unittest.cc',
On 2015/07/08 21:58:23, Nico wrote:
> ?

Woah, this is super random. I have no idea where this came from.

https://codereview.chromium.org/1224553010/diff/140001/media/video/capture/fa...
File media/video/capture/fake_video_capture_device_factory.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/media/video/capture/fa...
media/video/capture/fake_video_capture_device_factory.cc:29: else if
(base::EqualsCaseInsensitiveASCII(option, "triplanar") == 0)
On 2015/07/08 21:58:23, Nico wrote:
> remove == 0 at end

Good catch!

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_sniffer.cc
File net/base/mime_sniffer.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_sniffer....
net/base/mime_sniffer.cc:349: base::StringPiece(content, len));
On 2015/07/08 21:58:23, Nico wrote:
> This previously only compared the first len bytes of both strings – is this
> intentionally not a prefix change on the rhs?

len is actually the length of magic so it should be the same. I made the comment
clearer and added a DCHECK here that it's the case.

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/net/base/mime_util.cc#...
net/base/mime_util.cc:118: if (end_pos == ext.size() &&
On 2015/07/08 21:58:23, Nico wrote:
> I was about to say that EqualsCase...() already does an early check for size,
so
> you could delete this, but it's actually required to make the StringPiece()
> below not point at uninitialized memory if ext is long. A bit subtle.

Yeah, I added a comment for clarity.

https://codereview.chromium.org/1224553010/diff/140001/net/cookies/cookie_uti...
File net/cookies/cookie_util.cc (right):

https://codereview.chromium.org/1224553010/diff/140001/net/cookies/cookie_uti...
net/cookies/cookie_util.cc:129: token, base::StringPiece(kMonths[i], 3))) {
On 2015/07/08 21:58:24, Nico wrote:
> nit: StartsWith?

Actually this is not a nit, it's wrong as written since it used to be StartsWith
and isn't any more.

https://codereview.chromium.org/1224553010/diff/140001/net/http/http_request_...
File net/http/http_request_headers.cc (left):

https://codereview.chromium.org/1224553010/diff/140001/net/http/http_request_...
net/http/http_request_headers.cc:244: if (key.length() == it->key.length() &&
On 2015/07/08 21:58:24, Nico wrote:
> Don't you need this check in case one string piece is shorter than the other
and
> not 0 terminated? Without the check you end up comparing uninitialized memory
in
> one of the two string pieces in that case

I don't follow. the new base one deals exclusively in StringPieces so null
terminated or not and differing lengths should be irrelevant.
Implementation-wise, the first thing Equals does is check the length.

https://codereview.chromium.org/1224553010/diff/140001/net/tools/balsa/string...
File net/tools/balsa/string_piece_utils.h (left):

https://codereview.chromium.org/1224553010/diff/140001/net/tools/balsa/string...
net/tools/balsa/string_piece_utils.h:68: struct StringPieceUtils {
On 2015/07/08 21:58:24, Nico wrote:
> Is this the "we can't use chromium's base for we must build in google's
internal
> codebase" thing again? +rch

I don't think so. It's already including base/strings/string_piece.h which
doesn't match the google3 one (strings/string_piece.h).

And I already removed the other functions from here with rsleevi's approval
(there were more) so I'm assuming it's OK to remove this last one.

[brettw, 2015-07-08 22:35:26]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-08 22:37:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/160001

[Nico, 2015-07-08 22:44:34]

lgtm except for the gyp file which still removes test files randomly (and that
minor syntax error)

https://codereview.chromium.org/1224553010/diff/140001/net/http/http_request_...
File net/http/http_request_headers.cc (left):

https://codereview.chromium.org/1224553010/diff/140001/net/http/http_request_...
net/http/http_request_headers.cc:244: if (key.length() == it->key.length() &&
On 2015/07/08 22:35:17, brettw wrote:
> On 2015/07/08 21:58:24, Nico wrote:
> > Don't you need this check in case one string piece is shorter than the other
> and
> > not 0 terminated? Without the check you end up comparing uninitialized
memory
> in
> > one of the two string pieces in that case
> 
> I don't follow. the new base one deals exclusively in StringPieces so null
> terminated or not and differing lengths should be irrelevant.
> Implementation-wise, the first thing Equals does is check the length.

Yes, I confused myself here.

https://codereview.chromium.org/1224553010/diff/160001/chrome/chrome_tests_un...
File chrome/chrome_tests_unit.gypi (left):

https://codereview.chromium.org/1224553010/diff/160001/chrome/chrome_tests_un...
chrome/chrome_tests_unit.gypi:538:
'common/favicon/large_icon_url_parser_unittest.cc',
this still looks off. git branch issues?

https://codereview.chromium.org/1224553010/diff/160001/net/base/mime_sniffer.cc
File net/base/mime_sniffer.cc (right):

https://codereview.chromium.org/1224553010/diff/160001/net/base/mime_sniffer....
net/base/mime_sniffer.cc:348: DCHECK_EQ(strlen(magic_entry.magic, len);
this has fewer closing parens than opening ones

[commit-bot: I haz the power, 2015-07-08 22:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 22:49:05]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

(exceeded global retry quota)

[brettw, 2015-07-09 17:23:35]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 17:23:36]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1224553010/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 17:24:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/180001

[commit-bot: I haz the power, 2015-07-09 17:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 17:36:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-07-09 17:59:41]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 17:59:41]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1224553010/#ps200001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 18:01:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/200001

[commit-bot: I haz the power, 2015-07-09 18:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 18:13:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-07-09 19:22:46]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 19:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1224553010/#ps200002
(title: "crashpad hack")

[commit-bot: I haz the power, 2015-07-09 19:25:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/200002

[commit-bot: I haz the power, 2015-07-09 19:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 19:38:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-07-09 20:01:00]

brettw@chromium.org changed reviewers:
+ rsleevi@chromium.org

[brettw, 2015-07-09 20:01:01]

rsleevi: net

[brettw, 2015-07-09 20:25:04]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 20:25:05]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1224553010/#ps230001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 20:26:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/230001

[commit-bot: I haz the power, 2015-07-09 20:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 20:29:23]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

(exceeded global retry quota)

[mmenke, 2015-07-09 20:36:33]

mmenke@chromium.org changed reviewers:
- thakis@chromium.org

[brettw, 2015-07-09 22:16:26]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 22:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1224553010/#ps250001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 22:18:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/250001

[commit-bot: I haz the power, 2015-07-09 22:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 22:34:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-07-09 23:07:36]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 23:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1224553010/#ps270001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 23:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/270001

[commit-bot: I haz the power, 2015-07-09 23:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 23:20:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ryan Sleevi, 2015-07-10 12:43:38]

There's one BUG here indicated below.

Given that the CQ seems to be over eager to land this, I'm scared it may try to
land with my LGTM, but please fix before landing (or if the CQ lands right away,
fix right away & TBR me)

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_sniffer.cc
File net/base/mime_sniffer.cc (right):

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_sniffer....
net/base/mime_sniffer.cc:626: } else if ((pos + kDocTypePrefixLength - 1 <= end)
&&
BUG: You should have removed this -1, as you did on line 619, because you've
accounted for it on line 617

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_util.cc#...
net/base/mime_util.cc:120: // including uninitialized memory if ext is longer
than extensions.
Seems somewhat inconsistent that you documented this, but not in the immediate
file preceding.

[brettw, 2015-07-10 17:01:01]

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_sniffer.cc
File net/base/mime_sniffer.cc (right):

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_sniffer....
net/base/mime_sniffer.cc:626: } else if ((pos + kDocTypePrefixLength - 1 <= end)
&&
On 2015/07/10 12:43:38, Ryan Sleevi (slow through 7-15 wrote:
> BUG: You should have removed this -1, as you did on line 619, because you've
> accounted for it on line 617

Phew, thanks for catching!

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/1224553010/diff/270001/net/base/mime_util.cc#...
net/base/mime_util.cc:120: // including uninitialized memory if ext is longer
than extensions.
On 2015/07/10 12:43:38, Ryan Sleevi (slow through 7-15 wrote:
> Seems somewhat inconsistent that you documented this, but not in the immediate
> file preceding.

I find this case non-trivially more confusing compared to the previous files, I
think because of the way it's == and the variable names don't match up as
clearly. This comment is here because Nico mentioned this was a confusing case
(it wasn't in my original patch). Since we both agreed, I'm inclined to think
this case is actually more confusing and the commenting situation is
appropriate.

[brettw, 2015-07-10 17:01:33]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-10 17:01:33]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1224553010/#ps290001
(title: " ")

[commit-bot: I haz the power, 2015-07-10 17:02:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224553010/290001

[commit-bot: I haz the power, 2015-07-10 18:28:48]

Committed patchset #16 (id:290001)

[commit-bot: I haz the power, 2015-07-10 18:29:50]

Patchset 16 (id:??) landed as
https://crrev.com/8a800901b78a29e33bc91b48621cec72964a1f14
Cr-Commit-Position: refs/heads/master@{#338324}