components/policy/core/common/registry_dict_win.cc - Issue 1224553010: Replace base::str[n]casecmp with helper functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/registry_dict_win.cc

Issue 1224553010: Replace base::str[n]casecmp with helper functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/registry_dict_win.cc

diff --git a/components/policy/core/common/registry_dict_win.cc b/components/policy/core/common/registry_dict_win.cc

index 132adcaddea05d3f3d089f40d30928c0cf23b2cd..dd04beec1ab681aae19d9cccd075e0c5643cb8d2 100644

--- a/components/policy/core/common/registry_dict_win.cc

+++ b/components/policy/core/common/registry_dict_win.cc

@@ -136,7 +136,7 @@ scoped_ptr<base::Value> ConvertValue(const base::Value& value,

bool CaseInsensitiveStringCompare::operator()(const std::string& a,

const std::string& b) const {

- return base::strcasecmp(a.c_str(), b.c_str()) < 0;

+ return base::CompareCaseInsensitiveASCII(a, b) < 0;

}

RegistryDict::RegistryDict() {}