Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1224533003: Remove obsolete GetAccessorPair from ElementsAccessor (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete GetAccessorPair from ElementsAccessor BUG=v8:4137 LOG=n Committed: https://crrev.com/e7d64b3f60a59f1e2dfef32a5ed245105fa3d3b9 Cr-Commit-Position: refs/heads/master@{#29467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M src/elements.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/elements.cc View 3 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-02 16:31:45 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-03 11:33:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224533003/1
5 years, 5 months ago (2015-07-03 11:57:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-03 12:38:56 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 12:39:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7d64b3f60a59f1e2dfef32a5ed245105fa3d3b9
Cr-Commit-Position: refs/heads/master@{#29467}

Powered by Google App Engine
This is Rietveld 408576698