Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: src/elements.cc

Issue 1224533003: Remove obsolete GetAccessorPair from ElementsAccessor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/elements.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index 72c8bfd8cb80455f892c9bf9b9676fb067b1f244..2fb2c973229e27f06e7f06d849d65fbf55cd9f62 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -650,19 +650,6 @@ class ElementsAccessorBase : public ElementsAccessor {
UNREACHABLE();
}
- virtual MaybeHandle<AccessorPair> GetAccessorPair(
- Handle<JSObject> holder, uint32_t key,
- Handle<FixedArrayBase> backing_store) final {
- return ElementsAccessorSubclass::GetAccessorPairImpl(holder, key,
- backing_store);
- }
-
- static MaybeHandle<AccessorPair> GetAccessorPairImpl(
- Handle<JSObject> obj, uint32_t key,
- Handle<FixedArrayBase> backing_store) {
- return MaybeHandle<AccessorPair>();
- }
-
virtual void SetLength(Handle<JSArray> array, uint32_t length) final {
ElementsAccessorSubclass::SetLengthImpl(array, length,
handle(array->elements()));
@@ -1059,19 +1046,6 @@ class DictionaryElementsAccessor
object->set_elements(*new_dictionary);
}
- static MaybeHandle<AccessorPair> GetAccessorPairImpl(
- Handle<JSObject> obj, uint32_t key, Handle<FixedArrayBase> store) {
- Handle<SeededNumberDictionary> backing_store =
- Handle<SeededNumberDictionary>::cast(store);
- int entry = backing_store->FindEntry(key);
- if (entry != SeededNumberDictionary::kNotFound &&
- backing_store->DetailsAt(entry).type() == ACCESSOR_CONSTANT &&
- backing_store->ValueAt(entry)->IsAccessorPair()) {
- return handle(AccessorPair::cast(backing_store->ValueAt(entry)));
- }
- return MaybeHandle<AccessorPair>();
- }
-
static bool HasIndexImpl(FixedArrayBase* store, uint32_t index) {
DisallowHeapAllocation no_gc;
SeededNumberDictionary* dict = SeededNumberDictionary::cast(store);
@@ -1547,20 +1521,6 @@ class SloppyArgumentsElementsAccessor
}
}
- static MaybeHandle<AccessorPair> GetAccessorPairImpl(
- Handle<JSObject> obj, uint32_t key, Handle<FixedArrayBase> parameters) {
- Handle<FixedArray> parameter_map = Handle<FixedArray>::cast(parameters);
- Handle<Object> probe(GetParameterMapArg(*parameter_map, key),
- obj->GetIsolate());
- if (!probe->IsTheHole()) {
- return MaybeHandle<AccessorPair>();
- } else {
- // If not aliased, check the arguments.
- Handle<FixedArray> arguments(FixedArray::cast(parameter_map->get(1)));
- return ArgumentsAccessor::GetAccessorPairImpl(obj, key, arguments);
- }
- }
-
static void SetLengthImpl(Handle<JSArray> array, uint32_t length,
Handle<FixedArrayBase> parameter_map) {
// Sloppy arguments objects are not arrays.
« no previous file with comments | « src/elements.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698