Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 122443005: replace deprecated SkScalarRound/Floor/Ceil calls with more explicit variants (Closed)

Created:
6 years, 11 months ago by reed1
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

replace deprecated SkScalarRound/Floor/Ceil calls with more explicit variants BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243175

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -38 lines) Patch
M cc/output/software_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/badge_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/opacity_draw_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_utils_mac.mm View 2 chunks +8 lines, -8 lines 0 comments Download
M skia/ext/skia_utils_win.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 1 5 chunks +11 lines, -11 lines 0 comments Download
M skia/skia_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/gdi_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/path_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/path_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/path_x11.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/platform_font_pango.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
reed1
need cc OWNER
6 years, 11 months ago (2014-01-02 21:20:14 UTC) #1
reed1
need chrome/common OWNER
6 years, 11 months ago (2014-01-02 21:23:11 UTC) #2
f(malita)
lgtm, but more files to rid of SkScalarRound(): skia/ext/vector_platform_device_emf_win.cc skia/ext/skia_utils_win.cc ui/gfx/path_x11.cc ui/gfx/platform_font_pango.cc ui/gfx/path_win.cc ui/gfx/path_gtk.cc ui/gfx/gdi_util.cc
6 years, 11 months ago (2014-01-03 14:04:26 UTC) #3
reed1
On 2014/01/03 14:04:26, Florin Malita wrote: > lgtm, but more files to rid of SkScalarRound(): ...
6 years, 11 months ago (2014-01-03 21:20:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/122443005/120001
6 years, 11 months ago (2014-01-06 14:28:39 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43325
6 years, 11 months ago (2014-01-06 14:45:43 UTC) #6
Ben Goodger (Google)
lgtm for bits i can review
6 years, 11 months ago (2014-01-06 17:47:30 UTC) #7
Jered
I don't own any of this code.
6 years, 11 months ago (2014-01-06 17:49:54 UTC) #8
reed1
On 2014/01/06 17:49:54, Jered wrote: > I don't own any of this code. I saw ...
6 years, 11 months ago (2014-01-06 18:07:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/122443005/120001
6 years, 11 months ago (2014-01-06 18:09:08 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 21:49:40 UTC) #11
Message was sent while issue was closed. 
Change committed as 243175

Powered by Google App Engine
This is Rietveld 408576698