Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: skia/ext/skia_utils_mac.mm

Issue 122443005: replace deprecated SkScalarRound/Floor/Ceil calls with more explicit variants (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « skia/ext/opacity_draw_filter.cc ('k') | skia/ext/skia_utils_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "skia/ext/skia_utils_mac.h" 5 #include "skia/ext/skia_utils_mac.h"
6 6
7 #import <AppKit/AppKit.h> 7 #import <AppKit/AppKit.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/mac/scoped_cftyperef.h" 10 #include "base/mac/scoped_cftyperef.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 { rect.fLeft, rect.fTop }, 127 { rect.fLeft, rect.fTop },
128 { rect.fRight - rect.fLeft, rect.fBottom - rect.fTop } 128 { rect.fRight - rect.fLeft, rect.fBottom - rect.fTop }
129 }; 129 };
130 return cg_rect; 130 return cg_rect;
131 } 131 }
132 132
133 // Converts CGColorRef to the ARGB layout Skia expects. 133 // Converts CGColorRef to the ARGB layout Skia expects.
134 SkColor CGColorRefToSkColor(CGColorRef color) { 134 SkColor CGColorRefToSkColor(CGColorRef color) {
135 DCHECK(CGColorGetNumberOfComponents(color) == 4); 135 DCHECK(CGColorGetNumberOfComponents(color) == 4);
136 const CGFloat* components = CGColorGetComponents(color); 136 const CGFloat* components = CGColorGetComponents(color);
137 return SkColorSetARGB(SkScalarRound(255.0 * components[3]), // alpha 137 return SkColorSetARGB(SkScalarRoundToInt(255.0 * components[3]), // alpha
138 SkScalarRound(255.0 * components[0]), // red 138 SkScalarRoundToInt(255.0 * components[0]), // red
139 SkScalarRound(255.0 * components[1]), // green 139 SkScalarRoundToInt(255.0 * components[1]), // green
140 SkScalarRound(255.0 * components[2])); // blue 140 SkScalarRoundToInt(255.0 * components[2])); // blue
141 } 141 }
142 142
143 // Converts ARGB to CGColorRef. 143 // Converts ARGB to CGColorRef.
144 CGColorRef CGColorCreateFromSkColor(SkColor color) { 144 CGColorRef CGColorCreateFromSkColor(SkColor color) {
145 return CGColorCreateGenericRGB(SkColorGetR(color) / 255.0, 145 return CGColorCreateGenericRGB(SkColorGetR(color) / 255.0,
146 SkColorGetG(color) / 255.0, 146 SkColorGetG(color) / 255.0,
147 SkColorGetB(color) / 255.0, 147 SkColorGetB(color) / 255.0,
148 SkColorGetA(color) / 255.0); 148 SkColorGetA(color) / 255.0);
149 } 149 }
150 150
151 // Converts NSColor to ARGB 151 // Converts NSColor to ARGB
152 SkColor NSDeviceColorToSkColor(NSColor* color) { 152 SkColor NSDeviceColorToSkColor(NSColor* color) {
153 DCHECK([color colorSpace] == [NSColorSpace genericRGBColorSpace] || 153 DCHECK([color colorSpace] == [NSColorSpace genericRGBColorSpace] ||
154 [color colorSpace] == [NSColorSpace deviceRGBColorSpace]); 154 [color colorSpace] == [NSColorSpace deviceRGBColorSpace]);
155 CGFloat red, green, blue, alpha; 155 CGFloat red, green, blue, alpha;
156 color = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]]; 156 color = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
157 [color getRed:&red green:&green blue:&blue alpha:&alpha]; 157 [color getRed:&red green:&green blue:&blue alpha:&alpha];
158 return SkColorSetARGB(SkScalarRound(255.0 * alpha), 158 return SkColorSetARGB(SkScalarRoundToInt(255.0 * alpha),
159 SkScalarRound(255.0 * red), 159 SkScalarRoundToInt(255.0 * red),
160 SkScalarRound(255.0 * green), 160 SkScalarRoundToInt(255.0 * green),
161 SkScalarRound(255.0 * blue)); 161 SkScalarRoundToInt(255.0 * blue));
162 } 162 }
163 163
164 // Converts ARGB to NSColor. 164 // Converts ARGB to NSColor.
165 NSColor* SkColorToCalibratedNSColor(SkColor color) { 165 NSColor* SkColorToCalibratedNSColor(SkColor color) {
166 return [NSColor colorWithCalibratedRed:SkColorGetR(color) / 255.0 166 return [NSColor colorWithCalibratedRed:SkColorGetR(color) / 255.0
167 green:SkColorGetG(color) / 255.0 167 green:SkColorGetG(color) / 255.0
168 blue:SkColorGetB(color) / 255.0 168 blue:SkColorGetB(color) / 255.0
169 alpha:SkColorGetA(color) / 255.0]; 169 alpha:SkColorGetA(color) / 255.0];
170 } 170 }
171 171
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 // Apply content matrix. 428 // Apply content matrix.
429 SkMatrix skMatrix = canvas_->getTotalMatrix(); 429 SkMatrix skMatrix = canvas_->getTotalMatrix();
430 skMatrix.postTranslate(-SkIntToScalar(pt.fX), -SkIntToScalar(pt.fY)); 430 skMatrix.postTranslate(-SkIntToScalar(pt.fX), -SkIntToScalar(pt.fY));
431 CGAffineTransform affine = SkMatrixToCGAffineTransform(skMatrix); 431 CGAffineTransform affine = SkMatrixToCGAffineTransform(skMatrix);
432 CGContextConcatCTM(cgContext_, affine); 432 CGContextConcatCTM(cgContext_, affine);
433 433
434 return cgContext_; 434 return cgContext_;
435 } 435 }
436 436
437 } // namespace gfx 437 } // namespace gfx
OLDNEW
« no previous file with comments | « skia/ext/opacity_draw_filter.cc ('k') | skia/ext/skia_utils_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698