Fix individual tests to use the new location of test_controller.js

Fix individual tests to use the new location of test_controller.js

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1082

[vsm, 2013-02-06 22:27:43]

lgtm

[Emily Fortuna, 2013-02-06 22:44:55]

lgtm

https://codereview.chromium.org/12244003/diff/1/dom/Console.html
File dom/Console.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/Console.html#newcode1
dom/Console.html:1: <!-- Generated by generate_dartvm_layout_tests.py. Do not
edit. -->
I couldn't find this script anywhere.... should we delete this line or update
wherever that script is now?

[Siggi Cherem (dart-lang), 2013-02-06 23:51:52]

https://codereview.chromium.org/12244003/diff/1/dom/Console.html
File dom/Console.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/Console.html#newcode1
dom/Console.html:1: <!-- Generated by generate_dartvm_layout_tests.py. Do not
edit. -->
On 2013/02/06 22:44:56, Emily Fortuna wrote:
> I couldn't find this script anywhere.... should we delete this line or update
> wherever that script is now?

yeah, it's under multivm/trunk/tools

that's the file I updated in this other CL:
https://codereview.chromium.org/12224040/

[ricow1, 2013-02-07 06:51:53]

LGTM
I just want to be sure here:
The unittest path generated are relative to:
third_party/WebKit/LayoutTests/dart/dom
right?

https://codereview.chromium.org/12244003/diff/1/dom/Console.html
File dom/Console.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/Console.html#newcode4
dom/Console.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
style="visibility:hidden;display:none"></iframe>
This iframe will probably not load - unless you use a really old checkout :-)

https://codereview.chromium.org/12244003/diff/1/dom/DOMMap.html
File dom/DOMMap.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/DOMMap.html#newcode4
dom/DOMMap.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
style="visibility:hidden;display:none"></iframe>
Same as other comment, I don't think this exists

https://codereview.chromium.org/12244003/diff/1/dom/Geolocation.html
File dom/Geolocation.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/Geolocation.html#newcode7
dom/Geolocation.html:7: <iframe src="../../../../../dart/frog/tip/frogger.html"
style="visibility:hidden;display:none"></iframe>
non existent

https://codereview.chromium.org/12244003/diff/1/dom/Workers.html
File dom/Workers.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/Workers.html#newcode4
dom/Workers.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
style="visibility:hidden;display:none"></iframe>
ditto

[Siggi Cherem (dart-lang), 2013-02-07 17:18:55]

On 2013/02/07 06:51:53, ricow1 wrote:
> LGTM
> I just want to be sure here:
> The unittest path generated are relative to:
> third_party/WebKit/LayoutTests/dart/dom
> right?

they are relative to where the file is located. So yes for the tests under dom/,
but without the 'dom' part for package-test, Multiscript, and from security/ for
the last test bellow

> 
> https://codereview.chromium.org/12244003/diff/1/dom/Console.html
> File dom/Console.html (right):
> 
> https://codereview.chromium.org/12244003/diff/1/dom/Console.html#newcode4
> dom/Console.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
> style="visibility:hidden;display:none"></iframe>
> This iframe will probably not load - unless you use a really old checkout :-)
> 
> https://codereview.chromium.org/12244003/diff/1/dom/DOMMap.html
> File dom/DOMMap.html (right):
> 
> https://codereview.chromium.org/12244003/diff/1/dom/DOMMap.html#newcode4
> dom/DOMMap.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
> style="visibility:hidden;display:none"></iframe>
> Same as other comment, I don't think this exists
> 
> https://codereview.chromium.org/12244003/diff/1/dom/Geolocation.html
> File dom/Geolocation.html (right):
> 
> https://codereview.chromium.org/12244003/diff/1/dom/Geolocation.html#newcode7
> dom/Geolocation.html:7: <iframe
src="../../../../../dart/frog/tip/frogger.html"
> style="visibility:hidden;display:none"></iframe>
> non existent
> 
> https://codereview.chromium.org/12244003/diff/1/dom/Workers.html
> File dom/Workers.html (right):
> 
> https://codereview.chromium.org/12244003/diff/1/dom/Workers.html#newcode4
> dom/Workers.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
> style="visibility:hidden;display:none"></iframe>
> ditto

[Siggi Cherem (dart-lang), 2013-02-07 17:22:02]

cc'ing a few more in dart-dom team to see if anyone knows about those tests
referring to frog and frogium

https://codereview.chromium.org/12244003/diff/1/dom/Console.html
File dom/Console.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/Console.html#newcode4
dom/Console.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
style="visibility:hidden;display:none"></iframe>
On 2013/02/07 06:51:53, ricow1 wrote:
> This iframe will probably not load - unless you use a really old checkout :-)

Interesting - I was blindly updating the unittest references without looking at
what each test does. 

Are these tests used at all? should they be removed?

[Anton Muhin, 2013-02-08 13:38:51]

https://codereview.chromium.org/12244003/diff/1/dom/Console.html
File dom/Console.html (right):

https://codereview.chromium.org/12244003/diff/1/dom/Console.html#newcode4
dom/Console.html:4: <iframe src="../../../../../dart/frog/tip/frogger.html"
style="visibility:hidden;display:none"></iframe>
If memory serves, that used to run a complier.  I believe we can safely remove
it now.

On 2013/02/07 17:22:02, Siggi Cherem (dart-lang) wrote:
> On 2013/02/07 06:51:53, ricow1 wrote:
> > This iframe will probably not load - unless you use a really old checkout
:-)
> 
> Interesting - I was blindly updating the unittest references without looking
at
> what each test does. 
> 
> Are these tests used at all? should they be removed?