chrome/browser/android/shortcut_info.h - Issue 1224273003: webapps: propogate name and shortName from manifest to Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_info.h

Issue 1224273003: webapps: propogate name and shortName from manifest to Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix cl issues Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/shortcut_data_fetcher.cc ('K') | « chrome/browser/android/shortcut_helper.cc ('k') | chrome/browser/android/shortcut_info.cc » ('j') | chrome/browser/android/shortcut_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_info.h

diff --git a/chrome/browser/android/shortcut_info.h b/chrome/browser/android/shortcut_info.h

index 2f4fbff6e8b3eb62d94e52c21eb8c86b6bd4ac9d..cfb92f4d296c45fa4aecad1c9f32aac41f25a15d 100644

--- a/chrome/browser/android/shortcut_info.h

+++ b/chrome/browser/android/shortcut_info.h

@@ -29,6 +29,7 @@ struct ShortcutInfo {

ShortcutInfo();

explicit ShortcutInfo(const GURL& shortcut_url);

+ ~ShortcutInfo();

gone 2015/07/20 22:19:12 1) ~ShortcutInfo() = default; 2) Remove empty dest

Lalit Maganti 2015/07/21 09:07:27 Done.

Lalit Maganti 2015/07/21 17:22:24 I've had to revert this because of chromium style

// Updates the info based on the given |manifest|.

void UpdateFromManifest(const content::Manifest& manifest);

@@ -37,7 +38,9 @@ struct ShortcutInfo {

void UpdateSource(const Source source);

GURL url;

- base::string16 title;

+ base::string16 user_title;

+ base::string16 name;

+ base::string16 short_name;

content::Manifest::DisplayMode display;

blink::WebScreenOrientationLockType orientation;

Source source;