webapps: propogate name and shortName from manifest to Java

chrome/browser/android/shortcut_info.cc

Index: chrome/browser/android/shortcut_info.cc
diff --git a/chrome/browser/android/shortcut_info.cc b/chrome/browser/android/shortcut_info.cc
index 67e0c5549c344667fdc39db4fc854bd8da65ea7d..4f4d766f117656f2fda46cc9f818314548317e34 100644
--- a/chrome/browser/android/shortcut_info.cc
+++ b/chrome/browser/android/shortcut_info.cc
@@ -17,11 +17,19 @@ ShortcutInfo::ShortcutInfo(const GURL& shortcut_url)
       source(SOURCE_ADD_TO_HOMESCREEN) {
 }
 
+ShortcutInfo::~ShortcutInfo() {
+}
+
 void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {
-  if (!manifest.short_name.is_null())
-    title = manifest.short_name.string();
-  else if (!manifest.name.is_null())
-    title = manifest.name.string();
+  if (manifest.name.is_null()) {
+    short_name = manifest.short_name.string();
+    name = short_name;
+  } else if (manifest.short_name.is_null()) {
+    name = manifest.name.string();
+    short_name = name;
+  }

[mlamouri (slow - plz ping), 2015/07/20 23:55:59]

If neither manifest.short_name or manifest.name are null, does that mean
|short_name| and |name| will not be set? I'm pretty sure I'm missing something
:)

[Lalit Maganti, 2015/07/21 09:07:27]

No you're not missing anything - I was missing the else branch of this if
statement.

[Lalit Maganti, 2015/07/21 09:07:27]

No you aren't missing anything - I was missing the else branch of the if
statement.

+  if (!short_name.empty())
+    user_title = short_name;
 
   // Set the url based on the manifest value, if any.
   if (manifest.start_url.is_valid())